fix(settings): enable Tor conns for other flavs

Amolith created 2 weeks ago

Remove QuickConversationsService.isConversations() checks from
AppSettings.java (isUseTor, isExtendedConnectionOptions) to allow Tor
connections in non-Conversations flavours.

I tested by installing with a modified package ID, adding a new account,
enabling the Tor toggle, and seeing that 0 out of 1 accounts were
connected because Tor is unavailable. After installing/enabling Orbot
and waiting a bit, I had to toggle the account to get it to try again.

Fixes: https://todo.sr.ht/~singpolyma/soprani.ca/442

Change summary

src/main/java/eu/siacs/conversations/AppSettings.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/AppSettings.java

@@ -174,8 +174,7 @@ public class AppSettings {
     }
 
     public boolean isUseTor() {
-        return QuickConversationsService.isConversations()
-                && getBooleanPreference(USE_TOR, R.bool.use_tor);
+        return getBooleanPreference(USE_TOR, R.bool.use_tor);
     }
 
     public boolean isSendChatStates() {
@@ -183,8 +182,7 @@ public class AppSettings {
     }
 
     public boolean isExtendedConnectionOptions() {
-        return QuickConversationsService.isConversations()
-                && getBooleanPreference(
+        return getBooleanPreference(
                         AppSettings.SHOW_CONNECTION_OPTIONS, R.bool.show_connection_options);
     }