properly unregister bookmark from conversations when deleting bookmark

Daniel Gultsch created 8 years ago

Change summary

src/main/java/eu/siacs/conversations/entities/Bookmark.java            | 1 
src/main/java/eu/siacs/conversations/entities/Conversation.java        | 1 
src/main/java/eu/siacs/conversations/ui/ConferenceDetailsActivity.java | 3 
3 files changed, 4 insertions(+), 1 deletion(-)

Detailed changes

src/main/java/eu/siacs/conversations/entities/Bookmark.java

@@ -167,5 +167,6 @@ public class Bookmark extends Element implements ListItem {
 		if (this.mJoinedConversation != null) {
 			this.mJoinedConversation.deregisterWithBookmark();
 		}
+		this.mJoinedConversation = null;
 	}
 }

src/main/java/eu/siacs/conversations/entities/Conversation.java

@@ -782,6 +782,7 @@ public class Conversation extends AbstractEntity implements Blockable, Comparabl
 		if (this.bookmark != null) {
 			this.bookmark.setConversation(null);
 		}
+		this.bookmark = null;
 	}
 
 	public Bookmark getBookmark() {

src/main/java/eu/siacs/conversations/ui/ConferenceDetailsActivity.java

@@ -495,9 +495,10 @@ public class ConferenceDetailsActivity extends XmppActivity implements OnConvers
 	protected void deleteBookmark() {
 		Account account = mConversation.getAccount();
 		Bookmark bookmark = mConversation.getBookmark();
-		bookmark.unregisterConversation();
+		mConversation.deregisterWithBookmark();
 		account.getBookmarks().remove(bookmark);
 		xmppConnectionService.pushBookmarks(account);
+		updateView();
 	}
 
 	@Override