use javax api instead of BC for file decryption

Daniel Gultsch created

Change summary

src/main/java/eu/siacs/conversations/services/AbstractConnectionManager.java | 220 
1 file changed, 104 insertions(+), 116 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/services/AbstractConnectionManager.java 🔗

@@ -6,140 +6,128 @@ import android.content.pm.PackageManager;
 import android.os.Build;
 import android.os.PowerManager;
 import android.os.SystemClock;
-import android.util.Log;
 import android.util.Pair;
 
-import org.bouncycastle.crypto.engines.AESEngine;
-import org.bouncycastle.crypto.modes.AEADBlockCipher;
-import org.bouncycastle.crypto.modes.GCMBlockCipher;
-import org.bouncycastle.crypto.params.AEADParameters;
-import org.bouncycastle.crypto.params.KeyParameter;
-
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.security.InvalidAlgorithmParameterException;
-import java.security.InvalidKeyException;
-import java.security.NoSuchAlgorithmException;
 import java.util.concurrent.atomic.AtomicLong;
 
 import javax.crypto.Cipher;
 import javax.crypto.CipherInputStream;
 import javax.crypto.CipherOutputStream;
-import javax.crypto.NoSuchPaddingException;
 import javax.crypto.spec.IvParameterSpec;
 import javax.crypto.spec.SecretKeySpec;
 
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.entities.DownloadableFile;
+import eu.siacs.conversations.utils.Compatibility;
 
 public class AbstractConnectionManager {
-	protected XmppConnectionService mXmppConnectionService;
-
-	private static final int UI_REFRESH_THRESHOLD = 250;
-	private static final AtomicLong LAST_UI_UPDATE_CALL = new AtomicLong(0);
-
-	public AbstractConnectionManager(XmppConnectionService service) {
-		this.mXmppConnectionService = service;
-	}
-
-	public XmppConnectionService getXmppConnectionService() {
-		return this.mXmppConnectionService;
-	}
-
-	public long getAutoAcceptFileSize() {
-		return this.mXmppConnectionService.getLongPreference("auto_accept_file_size",R.integer.auto_accept_filesize);
-	}
-
-	public boolean hasStoragePermission() {
-		if (!Config.ONLY_INTERNAL_STORAGE && Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
-			return mXmppConnectionService.checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED;
-		} else {
-			return true;
-		}
-	}
-
-	public static Pair<InputStream,Integer> createInputStream(DownloadableFile file, boolean gcm) throws FileNotFoundException {
-		FileInputStream is;
-		int size;
-		is = new FileInputStream(file);
-		size = (int) file.getSize();
-		if (file.getKey() == null) {
-			return new Pair<>(is,size);
-		}
-		try {
-			if (gcm) {
-				AEADBlockCipher cipher = new GCMBlockCipher(new AESEngine());
-				cipher.init(true, new AEADParameters(new KeyParameter(file.getKey()), 128, file.getIv()));
-				InputStream cis = new org.bouncycastle.crypto.io.CipherInputStream(is, cipher);
-				return new Pair<>(cis, cipher.getOutputSize(size));
-			} else {
-				IvParameterSpec ips = new IvParameterSpec(file.getIv());
-				Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
-				cipher.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(file.getKey(), "AES"), ips);
-				Log.d(Config.LOGTAG, "opening encrypted input stream");
-				return new Pair<>(new CipherInputStream(is, cipher),(size / 16 + 1) * 16);
-			}
-		} catch (Exception e) {
-			throw new AssertionError(e);
-		}
-	}
-
-	public static OutputStream createAppendedOutputStream(DownloadableFile file) {
-		return createOutputStream(file, false, true);
-	}
-
-	public static OutputStream createOutputStream(DownloadableFile file, boolean gcm) {
-		return createOutputStream(file, gcm, false);
-	}
-
-	private static OutputStream createOutputStream(DownloadableFile file, boolean gcm, boolean append) {
-		FileOutputStream os;
-		try {
-			os = new FileOutputStream(file, append);
-			if (file.getKey() == null) {
-				return os;
-			}
-		} catch (FileNotFoundException e) {
-			return null;
-		}
-		try {
-			if (gcm) {
-				AEADBlockCipher cipher = new GCMBlockCipher(new AESEngine());
-				cipher.init(false, new AEADParameters(new KeyParameter(file.getKey()), 128, file.getIv()));
-				return new org.bouncycastle.crypto.io.CipherOutputStream(os, cipher);
-			} else {
-				IvParameterSpec ips = new IvParameterSpec(file.getIv());
-				Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
-				cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec(file.getKey(), "AES"), ips);
-				Log.d(Config.LOGTAG, "opening encrypted output stream");
-				return new CipherOutputStream(os, cipher);
-			}
-		} catch (InvalidKeyException e) {
-			return null;
-		} catch (NoSuchAlgorithmException e) {
-			return null;
-		} catch (NoSuchPaddingException e) {
-			return null;
-		} catch (InvalidAlgorithmParameterException e) {
-			return null;
-		}
-	}
-
-	public void updateConversationUi(boolean force) {
-		synchronized (LAST_UI_UPDATE_CALL) {
-			if (force || SystemClock.elapsedRealtime() - LAST_UI_UPDATE_CALL.get() >= UI_REFRESH_THRESHOLD) {
-				LAST_UI_UPDATE_CALL.set(SystemClock.elapsedRealtime());
-				mXmppConnectionService.updateConversationUi();
-			}
-		}
-	}
-
-	public PowerManager.WakeLock createWakeLock(String name) {
-		PowerManager powerManager = (PowerManager) mXmppConnectionService.getSystemService(Context.POWER_SERVICE);
-		return powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK,name);
-	}
+
+    private static final String KEYTYPE = "AES";
+    private static final String CIPHERMODE = "AES/GCM/NoPadding";
+    private static final String PROVIDER = "BC";
+    private static final int UI_REFRESH_THRESHOLD = 250;
+    private static final AtomicLong LAST_UI_UPDATE_CALL = new AtomicLong(0);
+    protected XmppConnectionService mXmppConnectionService;
+
+    public AbstractConnectionManager(XmppConnectionService service) {
+        this.mXmppConnectionService = service;
+    }
+
+    public static Pair<InputStream, Integer> createInputStream(DownloadableFile file, boolean gcm) throws FileNotFoundException {
+        FileInputStream is;
+        int size;
+        is = new FileInputStream(file);
+        size = (int) file.getSize();
+        if (file.getKey() == null) {
+            return new Pair<>(is, size);
+        }
+        try {
+            if (gcm) {
+                Cipher cipher = Compatibility.twentyTwo() ? Cipher.getInstance(CIPHERMODE) : Cipher.getInstance(CIPHERMODE, PROVIDER);
+                SecretKeySpec keySpec = new SecretKeySpec(file.getKey(), KEYTYPE);
+                IvParameterSpec ivSpec = new IvParameterSpec(file.getIv());
+                cipher.init(Cipher.ENCRYPT_MODE, keySpec, ivSpec);
+                return new Pair<>(new CipherInputStream(is, cipher), cipher.getOutputSize(size));
+            } else {
+                IvParameterSpec ips = new IvParameterSpec(file.getIv());
+                Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
+                cipher.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(file.getKey(), KEYTYPE), ips);
+                return new Pair<>(new CipherInputStream(is, cipher), (size / 16 + 1) * 16);
+            }
+        } catch (Exception e) {
+            throw new AssertionError(e);
+        }
+    }
+
+    public static OutputStream createAppendedOutputStream(DownloadableFile file) {
+        return createOutputStream(file, false, true);
+    }
+
+    public static OutputStream createOutputStream(DownloadableFile file, boolean gcm) {
+        return createOutputStream(file, gcm, false);
+    }
+
+    private static OutputStream createOutputStream(DownloadableFile file, boolean gcm, boolean append) {
+        FileOutputStream os;
+        try {
+            os = new FileOutputStream(file, append);
+            if (file.getKey() == null) {
+                return os;
+            }
+        } catch (FileNotFoundException e) {
+            return null;
+        }
+        try {
+            if (gcm) {
+                Cipher cipher = Compatibility.twentyTwo() ? Cipher.getInstance(CIPHERMODE) : Cipher.getInstance(CIPHERMODE, PROVIDER);
+                SecretKeySpec keySpec = new SecretKeySpec(file.getKey(), KEYTYPE);
+                IvParameterSpec ivSpec = new IvParameterSpec(file.getIv());
+                cipher.init(Cipher.DECRYPT_MODE, keySpec, ivSpec);
+                return new CipherOutputStream(os, cipher);
+            } else {
+                IvParameterSpec ips = new IvParameterSpec(file.getIv());
+                Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
+                cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec(file.getKey(), KEYTYPE), ips);
+                return new CipherOutputStream(os, cipher);
+            }
+        } catch (Exception e) {
+            throw new AssertionError(e);
+        }
+    }
+
+    public XmppConnectionService getXmppConnectionService() {
+        return this.mXmppConnectionService;
+    }
+
+    public long getAutoAcceptFileSize() {
+        return this.mXmppConnectionService.getLongPreference("auto_accept_file_size", R.integer.auto_accept_filesize);
+    }
+
+    public boolean hasStoragePermission() {
+        if (!Config.ONLY_INTERNAL_STORAGE && Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
+            return mXmppConnectionService.checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED;
+        } else {
+            return true;
+        }
+    }
+
+    public void updateConversationUi(boolean force) {
+        synchronized (LAST_UI_UPDATE_CALL) {
+            if (force || SystemClock.elapsedRealtime() - LAST_UI_UPDATE_CALL.get() >= UI_REFRESH_THRESHOLD) {
+                LAST_UI_UPDATE_CALL.set(SystemClock.elapsedRealtime());
+                mXmppConnectionService.updateConversationUi();
+            }
+        }
+    }
+
+    public PowerManager.WakeLock createWakeLock(String name) {
+        PowerManager powerManager = (PowerManager) mXmppConnectionService.getSystemService(Context.POWER_SERVICE);
+        return powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, name);
+    }
 }