Hide subject option when in legacy encryption

Stephen Paul Weber created 2 years ago

Change summary

src/main/java/eu/siacs/conversations/ui/ConversationFragment.java              | 1 
src/main/java/eu/siacs/conversations/ui/util/ConversationMenuConfigurator.java | 8 
2 files changed, 4 insertions(+), 5 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/ui/ConversationFragment.java

@@ -1629,6 +1629,7 @@ public class ConversationFragment extends XmppFragment
                 MenuItem newItem = menu.add(item.getGroupId(), item.getItemId(), item.getOrder(), item.getTitle());
                 newItem.setIcon(item.getIcon());
             }
+            ConversationMenuConfigurator.configureAttachmentMenu(conversation, menu);
             return;
         }
 

src/main/java/eu/siacs/conversations/ui/util/ConversationMenuConfigurator.java

@@ -60,11 +60,9 @@ public class ConversationMenuConfigurator {
 		} else {
 			visible = true;
 		}
-		menuAttach.setVisible(visible);
-		if (!visible) {
-			return;
-		}
-		menu.findItem(R.id.attach_record_voice).setVisible(microphoneAvailable);
+		if (menuAttach != null) menuAttach.setVisible(visible);
+		if (visible) menu.findItem(R.id.attach_record_voice).setVisible(microphoneAvailable);
+		menu.findItem(R.id.attach_subject).setVisible(conversation.getNextEncryption() == Message.ENCRYPTION_NONE);
 	}
 
 	public static void configureEncryptionMenu(@NonNull Conversation conversation, Menu menu) {