From 1deb58cd13127707b413799baf2f80e99a931d00 Mon Sep 17 00:00:00 2001 From: Stephen Paul Weber Date: Wed, 31 Aug 2022 09:10:26 -0500 Subject: [PATCH] Fix crash when menuInfo has no useful position --- .../siacs/conversations/ui/ConversationsOverviewFragment.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/eu/siacs/conversations/ui/ConversationsOverviewFragment.java b/src/main/java/eu/siacs/conversations/ui/ConversationsOverviewFragment.java index a5390618df4304d5ef17bb02de08da749d5986cc..09246d6af9c17203923cbe3d77f076b4bebb420b 100644 --- a/src/main/java/eu/siacs/conversations/ui/ConversationsOverviewFragment.java +++ b/src/main/java/eu/siacs/conversations/ui/ConversationsOverviewFragment.java @@ -329,7 +329,9 @@ public class ConversationsOverviewFragment extends XmppFragment { final MenuItem menuOngoingCall = menu.findItem(R.id.action_ongoing_call); final MenuItem menuTogglePinned = menu.findItem(R.id.action_toggle_pinned); - Conversation conversation = conversations.get(((AdapterContextMenuInfo) menuInfo).position); + int pos = ((AdapterContextMenuInfo) menuInfo).position; + if (pos < 0) return; + Conversation conversation = conversations.get(pos); if (conversation != null) { if (conversation.getMode() == Conversation.MODE_MULTI) { menuContactDetails.setVisible(false);