compareTo have to match on all items or sort may explode

Stephen Paul Weber created 2 years ago

Change summary

src/main/java/eu/siacs/conversations/entities/Bookmark.java | 6 ++++++
1 file changed, 6 insertions(+)

Detailed changes

src/main/java/eu/siacs/conversations/entities/Bookmark.java

@@ -154,6 +154,12 @@ public class Bookmark extends Element implements ListItem {
 
 	@Override
 	public int compareTo(final @NonNull ListItem another) {
+		if (getJid().isDomainJid() && !another.getJid().isDomainJid()) {
+			return -1;
+		} else if (!getJid().isDomainJid() && another.getJid().isDomainJid()) {
+			return 1;
+		}
+
 		return this.getDisplayName().compareToIgnoreCase(
 				another.getDisplayName());
 	}