If security exception, don't fail call

Stephen Paul Weber created 2 years ago

Change summary

src/main/java/eu/siacs/conversations/services/CallIntegrationConnectionService.java | 25 
1 file changed, 12 insertions(+), 13 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/services/CallIntegrationConnectionService.java

@@ -363,23 +363,22 @@ public class CallIntegrationConnectionService extends ConnectionService {
             }
             try {
                 service.getSystemService(TelecomManager.class).placeCall(address, extras);
+                return;
             } catch (final SecurityException e) {
                 Log.e(Config.LOGTAG, "call integration not available", e);
-                Toast.makeText(service, R.string.call_integration_not_available, Toast.LENGTH_LONG)
-                        .show();
-            }
-        } else {
-            final var connection = createOutgoingRtpConnection(service, account, with, media);
-            if (connection != null) {
-                Log.d(
-                        Config.LOGTAG,
-                        "not adding outgoing call to TelecomManager on Android "
-                                + Build.VERSION.RELEASE
-                                + " ("
-                                + Build.DEVICE
-                                + ")");
             }
         }
+
+        final var connection = createOutgoingRtpConnection(service, account, with, media);
+        if (connection != null) {
+            Log.d(
+                    Config.LOGTAG,
+                    "not adding outgoing call to TelecomManager on Android "
+                            + Build.VERSION.RELEASE
+                            + " ("
+                            + Build.DEVICE
+                            + ")");
+        }
     }
 
     private static PhoneAccountHandle findPhoneAccount(final Context context, final AbstractJingleConnection.Id id) {