Resolver: Only prefer VPN connections when network is active

Daniel Gultsch created 8 years ago

Change summary

src/main/java/eu/siacs/conversations/utils/AndroidUsingLinkProperties.java | 9 
1 file changed, 8 insertions(+), 1 deletion(-)

Detailed changes

src/main/java/eu/siacs/conversations/utils/AndroidUsingLinkProperties.java

@@ -39,13 +39,15 @@ public class AndroidUsingLinkProperties extends AbstractDNSServerLookupMechanism
         if (networks == null) {
             return new String[0];
         }
+        final Network activeNetwork = getActiveNetwork(connectivityManager);
         List<String> servers = new ArrayList<>();
         int vpnOffset = 0;
         for(Network network : networks) {
             LinkProperties linkProperties = connectivityManager.getLinkProperties(network);
             NetworkInfo networkInfo = connectivityManager.getNetworkInfo(network);
+            final boolean isActiveNetwork = network.equals(activeNetwork);
             if (linkProperties != null) {
-                if (networkInfo != null && networkInfo.getType() == ConnectivityManager.TYPE_VPN) {
+                if (networkInfo != null && isActiveNetwork && networkInfo.getType() == ConnectivityManager.TYPE_VPN) {
                     final List<String> tmp = getIPv4First(linkProperties.getDnsServers());
                     servers.addAll(0, tmp);
                     vpnOffset += tmp.size();
@@ -59,6 +61,11 @@ public class AndroidUsingLinkProperties extends AbstractDNSServerLookupMechanism
         return servers.toArray(new String[servers.size()]);
     }
 
+    @TargetApi(23)
+    private static Network getActiveNetwork(ConnectivityManager cm) {
+        return Build.VERSION.SDK_INT >= Build.VERSION_CODES.M ? cm.getActiveNetwork() : null;
+    }
+
     private static List<String> getIPv4First(List<InetAddress> in) {
         List<String> out = new ArrayList<>();
         for(InetAddress addr : in) {