From 51e5399908fdefe7e8aee2f6378e97f7b2e36994 Mon Sep 17 00:00:00 2001 From: Stephen Paul Weber Date: Wed, 13 Sep 2023 14:36:34 -0500 Subject: [PATCH] Disable bubble merging It messes with reply UI, etc --- .../siacs/conversations/entities/Message.java | 33 +------------------ 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/entities/Message.java b/src/main/java/eu/siacs/conversations/entities/Message.java index 16c19d485025b5625ad730c0d10c5b215734bf06..aedf2f325a3abe56a7b271abc071e8a005827f40 100644 --- a/src/main/java/eu/siacs/conversations/entities/Message.java +++ b/src/main/java/eu/siacs/conversations/entities/Message.java @@ -911,38 +911,7 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable } public boolean mergeable(final Message message) { - return message != null && - (message.getType() == Message.TYPE_TEXT && - this.getTransferable() == null && - message.getTransferable() == null && - message.getEncryption() != Message.ENCRYPTION_PGP && - message.getEncryption() != Message.ENCRYPTION_DECRYPTION_FAILED && - this.getType() == message.getType() && - isStatusMergeable(this.getStatus(), message.getStatus()) && - isEncryptionMergeable(this.getEncryption(),message.getEncryption()) && - this.getCounterpart() != null && - this.getCounterpart().equals(message.getCounterpart()) && - this.edited() == message.edited() && - (message.getTimeSent() - this.getTimeSent()) <= (Config.MESSAGE_MERGE_WINDOW * 1000) && - (this.getSubject() == null || this.getSubject().equals(message.getSubject())) && - (this.getThread() == null || (message.getThread() != null && this.getThread().toString().equals(message.getThread().toString()))) && - this.getBody().length() + message.getBody().length() <= Config.MAX_DISPLAY_MESSAGE_CHARS && - this.getModerated() == null && - !message.isGeoUri() && - !this.isGeoUri() && - !message.isOOb() && - !this.isOOb() && - !message.treatAsDownloadable() && - !this.treatAsDownloadable() && - !message.hasMeCommand() && - !this.hasMeCommand() && - !this.bodyIsOnlyEmojis() && - !message.bodyIsOnlyEmojis() && - ((this.axolotlFingerprint == null && message.axolotlFingerprint == null) || this.axolotlFingerprint.equals(message.getFingerprint())) && - UIHelper.sameDay(message.getTimeSent(), this.getTimeSent()) && - this.getReadByMarkers().equals(message.getReadByMarkers()) && - !this.conversation.getJid().asBareJid().equals(Config.BUG_REPORTS) - ); + return false; // Merrgine messages messes up reply, so disable for now } private static boolean isStatusMergeable(int a, int b) {