From 893c563ef541a6016108fa5d40e3191e8a76d7ea Mon Sep 17 00:00:00 2001 From: Stephen Paul Weber Date: Wed, 5 Feb 2025 13:24:28 -0500 Subject: [PATCH] Empty name or nick is invalid and unhelpful --- .../java/eu/siacs/conversations/generator/IqGenerator.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/generator/IqGenerator.java b/src/main/java/eu/siacs/conversations/generator/IqGenerator.java index 42ab107a1e92ee5a78eb9e9b994200fb24553b59..219547eee4ec565be71edc21a14c38ca00d1f84e 100644 --- a/src/main/java/eu/siacs/conversations/generator/IqGenerator.java +++ b/src/main/java/eu/siacs/conversations/generator/IqGenerator.java @@ -7,6 +7,7 @@ import android.util.Log; import com.cheogram.android.BobTransfer; +import com.google.common.base.Strings; import com.google.common.io.ByteStreams; import org.whispersystems.libsignal.IdentityKey; @@ -282,10 +283,10 @@ public class IqGenerator extends AbstractGenerator { final String password = bookmark.getPassword(); final boolean autojoin = bookmark.autojoin(); final Element conference = new Element("conference", Namespace.BOOKMARKS2); - if (name != null) { + if (!Strings.isNullOrEmpty(name)) { conference.setAttribute("name", name); } - if (nick != null) { + if (!Strings.isNullOrEmpty(nick)) { conference.addChild("nick").setContent(nick); } if (password != null) {