From a03b96b94b5c414f13e1040734e8885197df8d8e Mon Sep 17 00:00:00 2001 From: Daniel Gultsch Date: Mon, 23 Dec 2024 10:21:31 +0100 Subject: [PATCH] add todo --- .../java/eu/siacs/conversations/xmpp/XmppConnection.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/java/eu/siacs/conversations/xmpp/XmppConnection.java b/src/main/java/eu/siacs/conversations/xmpp/XmppConnection.java index 5762736cb591fc5d725f3d619db321b7d975d7a9..bd96bb96ce58c282ab30099699568759b03b935f 100644 --- a/src/main/java/eu/siacs/conversations/xmpp/XmppConnection.java +++ b/src/main/java/eu/siacs/conversations/xmpp/XmppConnection.java @@ -1595,6 +1595,11 @@ public class XmppConnection implements Runnable { hashTokenRequest = HashedToken.Mechanism.best( inline.getFastMechanisms(), SSLSockets.version(this.socket)); + // TODO warn or fail early if channel binding priority isn’t high enough compared to + // login mechanism + // ChannelBinding.priority(hashTokenRequest.channelBinding) + // < + // ChannelBindingMechanism.getPriority(saslMechanism) } else { hashTokenRequest = null; }