fixed dead lock when sending pgp messages from quick reply. fixes #3246

Daniel Gultsch created 7 years ago

Change summary

src/main/java/eu/siacs/conversations/crypto/PgpDecryptionService.java    | 2 
src/main/java/eu/siacs/conversations/services/XmppConnectionService.java | 2 
2 files changed, 1 insertion(+), 3 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/crypto/PgpDecryptionService.java

@@ -29,7 +29,7 @@ import eu.siacs.conversations.utils.MimeUtils;
 
 public class PgpDecryptionService {
 
-	protected final ArrayDeque<Message> messages = new ArrayDeque();
+	protected final ArrayDeque<Message> messages = new ArrayDeque<>();
 	protected final HashSet<Message> pendingNotifications = new HashSet<>();
 	private final XmppConnectionService mXmppConnectionService;
 	private OpenPgpApi openPgpApi = null;

src/main/java/eu/siacs/conversations/services/XmppConnectionService.java

@@ -802,8 +802,6 @@ public class XmppConnectionService extends Service {
             getPgpEngine().encrypt(message, new UiCallback<Message>() {
                 @Override
                 public void success(Message message) {
-                    message.setEncryption(Message.ENCRYPTION_DECRYPTED);
-                    sendMessage(message);
                     if (dismissAfterReply) {
                         markRead((Conversation) message.getConversation(), true);
                     } else {