Port in isApp logic from Borogove

Stephen Paul Weber created 1 month ago

Change summary

src/main/java/eu/siacs/conversations/entities/Contact.java      | 23 +++
src/main/java/eu/siacs/conversations/entities/Conversation.java |  2 
2 files changed, 24 insertions(+), 1 deletion(-)

Detailed changes

src/main/java/eu/siacs/conversations/entities/Contact.java

@@ -51,6 +51,7 @@ import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.utils.JidHelper;
 import eu.siacs.conversations.utils.UIHelper;
 import eu.siacs.conversations.xml.Element;
+import eu.siacs.conversations.xml.Namespace;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.jingle.RtpCapability;
 import eu.siacs.conversations.xmpp.pep.Avatar;
@@ -340,6 +341,28 @@ public class Contact implements ListItem, Blockable {
         return resource.equals("") ? getJid() : getJid().withResource(resource);
     }
 
+    public boolean isApp() {
+        if (getPresences().isEmpty()) {
+            // No caps so let's guess that domains are apps
+            return getJid().isDomainJid();
+        }
+
+        final var hasCommands = resourceWhichSupport(Namespace.COMMANDS) != null;
+        final var bot = getPresences().anyIdentity("client", "bot");
+        final var client = getPresences().anyIdentity("client", null);
+        final var account = getPresences().anyIdentity("account", null);
+
+        // Clients are not apps, we chat with them
+        if ((client || account) && !bot) return false;
+
+        final var conference = getPresences().anyIdentity("conference", null);
+        // A MUC component is an app
+        if (conference && getJid().isDomainJid()) return hasCommands;
+
+        // If it's not a client or conference, guess it's an app
+        return !client && !conference && hasCommands;
+    }
+
     public boolean setPhotoUri(String uri) {
         if (uri != null && !uri.equals(this.photoUri)) {
             this.photoUri = uri;

src/main/java/eu/siacs/conversations/entities/Conversation.java

@@ -1746,7 +1746,7 @@ public class Conversation extends AbstractEntity
     public int getCurrentTab() {
         if (mCurrentTab >= 0) return mCurrentTab;
 
-        if (!isRead(null) || getContact().resourceWhichSupport(Namespace.COMMANDS) == null) {
+        if (!getContact().isApp() || !isRead(null)) {
             return 0;
         }