From b94794083d66f0fed2599529fc3ac984d2196823 Mon Sep 17 00:00:00 2001 From: Phillip Davis Date: Wed, 22 Oct 2025 13:39:24 -0400 Subject: [PATCH] guard against null url in oob stanza previously, would crash whole app `if (url != null) {` makes it seem like we were fine with the subsequent code not running anyway --- .../java/eu/siacs/conversations/entities/Conversation.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/java/eu/siacs/conversations/entities/Conversation.java b/src/main/java/eu/siacs/conversations/entities/Conversation.java index b424cc9d4949fffdd5e0fd2bd710a8c213f471e8..50842229977430bd2bedf10a807e6001ed4b1b75 100644 --- a/src/main/java/eu/siacs/conversations/entities/Conversation.java +++ b/src/main/java/eu/siacs/conversations/entities/Conversation.java @@ -3241,6 +3241,9 @@ public class Conversation extends AbstractEntity String url = el.findChildContent("url", "jabber:x:oob"); if (url != null) { String scheme = Uri.parse(url).getScheme(); + if (scheme == null) { + break; + } if (scheme.equals("http") || scheme.equals("https")) { this.responseElement = el; break;