use escaped form of jid where approriate

Daniel Gultsch created 7 years ago

Change summary

src/main/java/eu/siacs/conversations/entities/Account.java             | 4 
src/main/java/eu/siacs/conversations/ui/ConferenceDetailsActivity.java | 2 
src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java    | 2 
src/main/java/eu/siacs/conversations/xmpp/stanzas/AbstractStanza.java  | 8 
4 files changed, 8 insertions(+), 8 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/entities/Account.java

@@ -618,7 +618,7 @@ public class Account extends AbstractEntity {
 
 	public String getShareableUri() {
 		List<XmppUri.Fingerprint> fingerprints = this.getFingerprints();
-		String uri = "xmpp:"+this.getJid().asBareJid().toString();
+		String uri = "xmpp:"+this.getJid().asBareJid().toEscapedString();
 		if (fingerprints.size() > 0) {
 			return XmppUri.getFingerprintUri(uri,fingerprints,';');
 		} else {
@@ -628,7 +628,7 @@ public class Account extends AbstractEntity {
 
 	public String getShareableLink() {
 		List<XmppUri.Fingerprint> fingerprints = this.getFingerprints();
-		String uri = "https://conversations.im/i/"+this.getJid().asBareJid().toString();
+		String uri = "https://conversations.im/i/"+this.getJid().asBareJid().toEscapedString();
 		if (fingerprints.size() > 0) {
 			return XmppUri.getFingerprintUri(uri,fingerprints,'&');
 		} else {

src/main/java/eu/siacs/conversations/ui/ConferenceDetailsActivity.java

@@ -329,7 +329,7 @@ public class ConferenceDetailsActivity extends XmppActivity implements OnConvers
 	protected String getShareableUri(boolean http) {
 		if (mConversation != null) {
 			if (http) {
-				return "https://conversations.im/j/"+ mConversation.getJid().asBareJid();
+				return "https://conversations.im/j/"+ mConversation.getJid().asBareJid().toEscapedString();
 			} else {
 				return "xmpp:"+mConversation.getJid().asBareJid()+"?join";
 			}

src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java

@@ -167,7 +167,7 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
 	protected String getShareableUri(boolean http) {
 		final String prefix = http ? "https://conversations.im/i/" : "xmpp:";
 		if (contact != null) {
-			return prefix+contact.getJid().asBareJid().toString();
+			return prefix+contact.getJid().asBareJid().toEscapedString();
 		} else {
 			return "";
 		}

src/main/java/eu/siacs/conversations/xmpp/stanzas/AbstractStanza.java

@@ -20,26 +20,26 @@ public class AbstractStanza extends Element {
 
 	public void setTo(final Jid to) {
 		if (to != null) {
-			setAttribute("to", to.toString());
+			setAttribute("to", to.toEscapedString());
 		}
 	}
 
 	public void setFrom(final Jid from) {
 		if (from != null) {
-			setAttribute("from", from.toString());
+			setAttribute("from", from.toEscapedString());
 		}
 	}
 
 	public boolean fromServer(final Account account) {
 		return getFrom() == null
-			|| getFrom().equals(account.getServer())
+			|| getFrom().equals(Jid.of(account.getServer()))
 			|| getFrom().equals(account.getJid().asBareJid())
 			|| getFrom().equals(account.getJid());
 	}
 
 	public boolean toServer(final Account account) {
 		return getTo() == null
-			|| getTo().equals(account.getServer())
+			|| getTo().equals(Jid.of(account.getServer()))
 			|| getTo().equals(account.getJid().asBareJid())
 			|| getTo().equals(account.getJid());
 	}