leave code comment about xmpp vs jabber vcard entry

Daniel Gultsch created 4 years ago

Change summary

src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java | 3 
1 file changed, 3 insertions(+)

Detailed changes

src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java

@@ -155,6 +155,8 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
             } else {
                 intent.putExtra(Intents.Insert.IM_HANDLE, value);
                 intent.putExtra(Intents.Insert.IM_PROTOCOL, CommonDataKinds.Im.PROTOCOL_JABBER);
+                //TODO for modern use we want PROTOCOL_CUSTOM and an extra field with a value of 'XMPP'
+                // however we don’t have such a field and thus have to use the legacy PROTOCOL_JABBER
             }
             intent.putExtra("finishActivityOnSaveCompleted", true);
             try {
@@ -249,6 +251,7 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
 
     @Override
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
+        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         if (grantResults.length > 0)
             if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                 if (requestCode == REQUEST_SYNC_CONTACTS && xmppConnectionServiceBound) {