refactore exceptionhandler to have one line file writer

Daniel Gultsch created 9 years ago

Change summary

src/main/java/eu/siacs/conversations/utils/DNSHelper.java        |  3 
src/main/java/eu/siacs/conversations/utils/ExceptionHandler.java | 14 -
src/main/java/eu/siacs/conversations/utils/ExceptionHelper.java  | 12 +
3 files changed, 16 insertions(+), 13 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/utils/DNSHelper.java

@@ -47,7 +47,10 @@ public class DNSHelper {
 
 	protected static Client client = new Client();
 
+	protected static Context context;
+
 	public static Bundle getSRVRecord(final Jid jid, Context context) throws IOException {
+		DNSHelper.context = context;
         final String host = jid.getDomainpart();
 		final List<InetAddress> servers = Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP ? getDnsServers(context) : getDnsServersPreLollipop();
 		Bundle b = new Bundle();

src/main/java/eu/siacs/conversations/utils/ExceptionHandler.java

@@ -27,19 +27,7 @@ public class ExceptionHandler implements UncaughtExceptionHandler {
 		ex.printStackTrace(printWriter);
 		String stacktrace = result.toString();
 		printWriter.close();
-		try {
-			OutputStream os = context.openFileOutput("stacktrace.txt",
-					Context.MODE_PRIVATE);
-			os.write(stacktrace.getBytes());
-			os.flush();
-			os.close();
-		} catch (FileNotFoundException e) {
-			// TODO Auto-generated catch block
-			e.printStackTrace();
-		} catch (IOException e) {
-			// TODO Auto-generated catch block
-			e.printStackTrace();
-		}
+		ExceptionHelper.writeToStacktraceFile(context, stacktrace);
 		this.defaultHandler.uncaughtException(thread, ex);
 	}
 

src/main/java/eu/siacs/conversations/utils/ExceptionHelper.java

@@ -14,8 +14,10 @@ import android.util.Log;
 
 import java.io.BufferedReader;
 import java.io.FileInputStream;
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.io.OutputStream;
 import java.util.List;
 
 import eu.siacs.conversations.Config;
@@ -118,4 +120,14 @@ public class ExceptionHelper {
 			return false;
 		}
 	}
+
+	public static void writeToStacktraceFile(Context context, String msg) {
+		try {
+			OutputStream os = context.openFileOutput("stacktrace.txt", Context.MODE_PRIVATE);
+			os.write(msg.getBytes());
+			os.flush();
+			os.close();
+		} catch (IOException ignored) {
+		}
+	}
 }