don't use a bookmarks name if it's empty

Daniel Gultsch created 9 years ago

Change summary

src/main/java/eu/siacs/conversations/entities/Bookmark.java     | 5 +-
src/main/java/eu/siacs/conversations/entities/Conversation.java | 6 ++-
2 files changed, 7 insertions(+), 4 deletions(-)

Detailed changes

src/main/java/eu/siacs/conversations/entities/Bookmark.java

@@ -52,8 +52,9 @@ public class Bookmark extends Element implements ListItem {
 	public String getDisplayName() {
 		if (this.mJoinedConversation != null) {
 			return this.mJoinedConversation.getName();
-		} else if (getBookmarkName() != null) {
-			return getBookmarkName();
+		} else if (getBookmarkName() != null
+				&& !getBookmarkName().trim().isEmpty()) {
+			return getBookmarkName().trim();
 		} else {
 			return this.getJid().getLocalpart();
 		}

src/main/java/eu/siacs/conversations/entities/Conversation.java

@@ -433,8 +433,10 @@ public class Conversation extends AbstractEntity implements Blockable {
 		if (getMode() == MODE_MULTI) {
 			if (getMucOptions().getSubject() != null) {
 				return getMucOptions().getSubject();
-			} else if (bookmark != null && bookmark.getBookmarkName() != null) {
-				return bookmark.getBookmarkName();
+			} else if (bookmark != null
+					&& bookmark.getBookmarkName() != null
+					&& !bookmark.getBookmarkName().trim().isEmpty()) {
+				return bookmark.getBookmarkName().trim();
 			} else {
 				String generatedName = getMucOptions().createNameFromParticipants();
 				if (generatedName != null) {