Stop double updates from MUC

Stephen Paul Weber created 2 years ago

Change summary

src/cheogram/java/com/cheogram/android/WebxdcPage.java                |  1 
src/cheogram/java/com/cheogram/android/WebxdcUpdate.java              |  6 
src/main/java/eu/siacs/conversations/parser/MessageParser.java        |  1 
src/main/java/eu/siacs/conversations/persistance/DatabaseBackend.java | 11 
4 files changed, 17 insertions(+), 2 deletions(-)

Detailed changes

src/cheogram/java/com/cheogram/android/WebxdcPage.java

@@ -294,6 +294,7 @@ public class WebxdcPage implements ConversationPage {
 			xmppConnectionService.sendMessage(message);
 			xmppConnectionService.insertWebxdcUpdate(new WebxdcUpdate(
 				(Conversation) message.getConversation(),
+				message.getUuid(),
 				selfJid(),
 				message.getThread(),
 				params.optString("info", null),

src/cheogram/java/com/cheogram/android/WebxdcUpdate.java

@@ -14,6 +14,7 @@ public class WebxdcUpdate {
 	protected final Long serial;
 	protected final Long maxSerial;
 	protected final String conversationId;
+	protected final String messageId;
 	protected final Jid sender;
 	protected final String thread;
 	protected final String threadParent;
@@ -22,10 +23,11 @@ public class WebxdcUpdate {
 	protected final String summary;
 	protected final String payload;
 
-	public WebxdcUpdate(final Conversation conversation, final Jid sender, final Element thread, final String info, final String document, final String summary, final String payload) {
+	public WebxdcUpdate(final Conversation conversation, final String messageId, final Jid sender, final Element thread, final String info, final String document, final String summary, final String payload) {
 		this.serial = null;
 		this.maxSerial = null;
 		this.conversationId = conversation.getUuid();
+		this.messageId = messageId;
 		this.sender = sender;
 		this.thread = thread.getContent();
 		this.threadParent = thread.getAttribute("parent");
@@ -39,6 +41,7 @@ public class WebxdcUpdate {
 		this.maxSerial = maxSerial;
 		this.serial = cursor.getLong(cursor.getColumnIndex("serial"));
 		this.conversationId = cursor.getString(cursor.getColumnIndex(Message.CONVERSATION));
+		this.messageId = cursor.getString(cursor.getColumnIndex("message_id"));
 		this.sender = Jid.of(cursor.getString(cursor.getColumnIndex("sender")));
 		this.thread = cursor.getString(cursor.getColumnIndex("thread"));
 		this.threadParent = cursor.getString(cursor.getColumnIndex("threadParent"));
@@ -55,6 +58,7 @@ public class WebxdcUpdate {
 	public ContentValues getContentValues() {
 		ContentValues cv = new ContentValues();
 		cv.put(Message.CONVERSATION, conversationId);
+		cv.put("message_id", messageId);
 		cv.put("sender", sender.toEscapedString());
 		cv.put("thread", thread);
 		cv.put("threadParent", threadParent);

src/main/java/eu/siacs/conversations/parser/MessageParser.java

@@ -536,6 +536,7 @@ public class MessageParser extends AbstractParser implements OnMessagePacketRece
             }
             mXmppConnectionService.insertWebxdcUpdate(new WebxdcUpdate(
                 conversation,
+                remoteMsgId,
                 counterpart,
                 packet.findChild("thread"),
                 body == null ? null : body.content,

src/main/java/eu/siacs/conversations/persistance/DatabaseBackend.java

@@ -311,6 +311,15 @@ public class DatabaseBackend extends SQLiteOpenHelper {
                 db.execSQL("PRAGMA cheogram.user_version = 8");
 				}
 
+            if(cheogramVersion < 9) {
+                db.execSQL(
+                    "ALTER TABLE cheogram.webxdc_updates " +
+                    "ADD COLUMN message_id TEXT"
+                );
+                db.execSQL("CREATE UNIQUE INDEX cheogram.webxdc_message_id_index ON webxdc_updates (" + Message.CONVERSATION + ", message_id)");
+                db.execSQL("PRAGMA cheogram.user_version = 9");
+            }
+
             db.setTransactionSuccessful();
         } finally {
             db.endTransaction();
@@ -854,7 +863,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
 
     public void insertWebxdcUpdate(final WebxdcUpdate update) {
         SQLiteDatabase db = this.getWritableDatabase();
-        db.insert("cheogram.webxdc_updates", null, update.getContentValues());
+        db.insertWithOnConflict("cheogram.webxdc_updates", null, update.getContentValues(), SQLiteDatabase.CONFLICT_IGNORE);
     }
 
     public WebxdcUpdate findLastWebxdcUpdate(Message message) {