From ffc1daaa56f1246c97777c1c74b18e204dbc69e2 Mon Sep 17 00:00:00 2001
From: Stephen Paul Weber <singpolyma@singpolyma.net>
Date: Wed, 16 Feb 2022 16:04:19 -0500
Subject: [PATCH] any means none means false (ie there exist) unless upstream
 reports a reason

---
 src/main/java/eu/siacs/conversations/entities/Presences.java   | 3 ++-
 .../eu/siacs/conversations/services/XmppConnectionService.java | 3 +--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/eu/siacs/conversations/entities/Presences.java b/src/main/java/eu/siacs/conversations/entities/Presences.java
index d0a25e884d52d0f3274bbceb0c961b99c1ccd5de..4753e2138f7e4949a00d2180e2253f5434c2a78f 100644
--- a/src/main/java/eu/siacs/conversations/entities/Presences.java
+++ b/src/main/java/eu/siacs/conversations/entities/Presences.java
@@ -152,7 +152,8 @@ public class Presences {
     public boolean anyIdentity(final String category, final String type) {
         synchronized (this.presences) {
             if (this.presences.size() == 0) {
-                return true;
+                // https://github.com/iNPUTmice/Conversations/issues/4230
+                return false;
             }
             for (Presence presence : this.presences.values()) {
                 ServiceDiscoveryResult disco = presence.getServiceDiscoveryResult();
diff --git a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java
index 9c533e4905df42f2e96fa22295657518410556b2..c6e79d3af47ae6db8c5063a675c4dacc970befa5 100644
--- a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java
+++ b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java
@@ -234,8 +234,7 @@ public class XmppConnectionService extends Service {
             }
         }
 
-        if (contact.getPresences().size() > 0 &&
-            contact.getPresences().anyIdentity("gateway", "pstn")) {
+        if (contact.getPresences().anyIdentity("gateway", "pstn")) {
             contact.registerAsPhoneAccount(this);
         }
     };