1// SPDX-FileCopyrightText: Amolith <amolith@secluded.site>
2//
3// SPDX-License-Identifier: LicenseRef-MutuaL-1.2
4
5package mcp
6
7import (
8 "context"
9 "encoding/json"
10 "strings"
11 "testing"
12
13 sdk "github.com/modelcontextprotocol/go-sdk/mcp"
14
15 "git.secluded.site/cooked-mcp/internal/cooked"
16)
17
18func TestCallToolACIDToolsSurface1ReadsShoppingList(t *testing.T) {
19 backend := &fakeBackend{shoppingList: cooked.ShoppingList{
20 Aisles: []cooked.Aisle{{
21 ID: "pantry",
22 Name: "Pantry",
23 ProductGroups: []cooked.ProductGroup{{
24 ID: "pasta",
25 Name: "Pasta",
26 Quantity: "200g",
27 }},
28 }},
29 }}
30 server := NewServer(backend, "test")
31
32 output, err := server.CallReadTool(context.Background(), ReadArguments{Target: "shopping_list"})
33 if err != nil {
34 t.Fatalf("CallReadTool() error = %v", err)
35 }
36
37 if len(output.Aisles) != 1 {
38 t.Fatalf("structured aisles = %d, want 1", len(output.Aisles))
39 }
40 if output.Aisles[0].ProductGroups[0].Name != "Pasta" {
41 t.Fatalf("first item = %q, want Pasta", output.Aisles[0].ProductGroups[0].Name)
42 }
43}
44
45func TestCallToolACIDRecipesRead1ListsRecipes(t *testing.T) {
46 backend := &fakeBackend{
47 recipes: []cooked.RecipeCard{
48 {ID: "recipe-1", Title: "Pasta", ThumbnailURL: "https://example.invalid/thumb.jpg"},
49 },
50 }
51 server := NewServer(backend, "test")
52
53 output, err := server.CallReadTool(context.Background(), ReadArguments{Target: "recipes", Page: 2, Limit: 5})
54 if err != nil {
55 t.Fatalf("CallReadTool() error = %v", err)
56 }
57
58 if backend.page != 2 {
59 t.Fatalf("backend page = %d, want 2", backend.page)
60 }
61 if backend.limit != 5 {
62 t.Fatalf("backend limit = %d, want 5", backend.limit)
63 }
64 if len(output.Recipes) != 1 {
65 t.Fatalf("structured recipes = %d, want 1", len(output.Recipes))
66 }
67 if output.Recipes[0].ID != "recipe-1" || output.Recipes[0].Title != "Pasta" {
68 t.Fatalf("first recipe = %#v, want recipe-1 Pasta", output.Recipes[0])
69 }
70}
71
72func TestCallToolACIDRecipesPagination4DefaultsAndCapsRecipeLimit(t *testing.T) {
73 backend := &fakeBackend{}
74 server := NewServer(backend, "test")
75
76 _, err := server.CallReadTool(context.Background(), ReadArguments{Target: "recipes", Limit: 99})
77 if err != nil {
78 t.Fatalf("CallReadTool() error = %v", err)
79 }
80
81 if backend.page != 1 {
82 t.Fatalf("backend page = %d, want default page 1", backend.page)
83 }
84 if backend.limit != 30 {
85 t.Fatalf("backend limit = %d, want capped limit 30", backend.limit)
86 }
87}
88
89func TestCallToolACIDRecipesRead2SearchesRecipes(t *testing.T) {
90 backend := &fakeBackend{searchRecipes: []cooked.RecipeCard{
91 {ID: "recipe-1", Title: "Pasta", ThumbnailURL: "https://example.invalid/thumb.jpg"},
92 {ID: "recipe-2", Title: "Tomato Pasta", ThumbnailURL: "https://example.invalid/thumb2.jpg"},
93 }}
94 server := NewServer(backend, "test")
95
96 output, err := server.CallReadTool(context.Background(), ReadArguments{
97 Target: "recipes",
98 Query: " pasta ",
99 Page: 2,
100 Limit: 1,
101 })
102 if err != nil {
103 t.Fatalf("CallReadTool() error = %v", err)
104 }
105
106 if backend.searchQuery != "pasta" {
107 t.Fatalf("backend search query = %q, want pasta", backend.searchQuery)
108 }
109 if backend.searchPage != 2 {
110 t.Fatalf("backend search page = %d, want 2", backend.searchPage)
111 }
112 if len(output.Recipes) != 1 {
113 t.Fatalf("structured recipes = %d, want truncated result length 1", len(output.Recipes))
114 }
115 if output.Recipes[0].ID != "recipe-1" || output.Recipes[0].Title != "Pasta" {
116 t.Fatalf("first recipe = %#v, want recipe-1 Pasta", output.Recipes[0])
117 }
118}
119
120func TestCallToolACIDRecipesRead5ReadsSingleRecipe(t *testing.T) {
121 backend := &fakeBackend{
122 recipeMetadata: cooked.RecipeMetadata{
123 Title: "Pasta",
124 ImageURLs: []string{"https://example.invalid/pasta.jpg"},
125 Owner: "returned-user",
126 EditPermission: true,
127 },
128 recipeContent: cooked.RecipeContent{
129 Content: "# Pasta\n\n- 200g pasta\n\n1. Boil pasta.",
130 Portions: 2,
131 },
132 }
133 server := NewServer(backend, "test")
134
135 result, output, err := server.callReadTool(
136 context.Background(),
137 nil,
138 ReadArguments{Target: "recipe", RecipeID: "recipe-1"},
139 )
140 if err != nil {
141 t.Fatalf("callReadTool() error = %v", err)
142 }
143
144 requireSingleRecipeBackendCalls(t, backend)
145 requireSingleRecipeOutput(t, output)
146 requireNoImageLeak(t, result, output)
147}
148
149func requireSingleRecipeBackendCalls(t *testing.T, backend *fakeBackend) {
150 t.Helper()
151
152 if backend.metadataRecipeID != "recipe-1" || backend.contentRecipeID != "recipe-1" {
153 t.Fatalf(
154 "backend recipe IDs = metadata %q content %q, want recipe-1",
155 backend.metadataRecipeID,
156 backend.contentRecipeID,
157 )
158 }
159 if backend.metadataCalls != 1 || backend.contentCalls != 1 {
160 t.Fatalf("backend calls = metadata %d content %d, want 1/1", backend.metadataCalls, backend.contentCalls)
161 }
162}
163
164func requireSingleRecipeOutput(t *testing.T, output ReadOutput) {
165 t.Helper()
166
167 if output.Recipe == nil {
168 t.Fatal("structured recipe is nil")
169 }
170 if output.Recipe.ID != "recipe-1" || output.Recipe.Title != "Pasta" {
171 t.Fatalf("structured recipe identity = %#v, want recipe-1 Pasta", output.Recipe)
172 }
173 if output.Recipe.Owner != "returned-user" || !output.Recipe.EditPermission {
174 t.Fatalf(
175 "structured recipe owner/edit = %q/%v, want returned-user/true",
176 output.Recipe.Owner,
177 output.Recipe.EditPermission,
178 )
179 }
180 if output.Recipe.Content != "# Pasta\n\n- 200g pasta\n\n1. Boil pasta." || output.Recipe.Portions != 2 {
181 t.Fatalf(
182 "structured recipe content/portions = %q/%d, want markdown/2",
183 output.Recipe.Content,
184 output.Recipe.Portions,
185 )
186 }
187}
188
189func requireNoImageLeak(t *testing.T, result *sdk.CallToolResult, output ReadOutput) {
190 t.Helper()
191
192 encodedOutput, err := json.Marshal(output)
193 if err != nil {
194 t.Fatalf("marshal output: %v", err)
195 }
196 if strings.Contains(string(encodedOutput), "image") ||
197 strings.Contains(string(encodedOutput), "https://example.invalid/pasta.jpg") {
198 t.Fatalf("structured output leaked image data: %s", encodedOutput)
199 }
200 if len(result.Content) != 1 {
201 t.Fatalf("text content length = %d, want 1", len(result.Content))
202 }
203 textContent, ok := result.Content[0].(*sdk.TextContent)
204 if !ok {
205 t.Fatalf("content type = %T, want *sdk.TextContent", result.Content[0])
206 }
207 if strings.Contains(textContent.Text, "https://example.invalid/pasta.jpg") {
208 t.Fatalf("text output leaked image URL: %s", textContent.Text)
209 }
210}
211
212func TestCallToolACIDToolsReadTool3RequiresRecipeIDForRecipeTarget(t *testing.T) {
213 backend := &fakeBackend{}
214 server := NewServer(backend, "test")
215
216 _, err := server.CallReadTool(context.Background(), ReadArguments{Target: "recipe", RecipeID: " "})
217 if err == nil {
218 t.Fatal("CallReadTool() error = nil, want missing recipe_id error")
219 }
220
221 if backend.metadataCalls != 0 || backend.contentCalls != 0 {
222 t.Fatalf("backend calls = metadata %d content %d, want none", backend.metadataCalls, backend.contentCalls)
223 }
224}
225
226func TestCallToolACIDRecipesPreviewText1PreviewsRawText(t *testing.T) {
227 backend := &fakeBackend{preview: cooked.RecipeTextPreview{
228 Title: "Pasta with Tomato Sauce",
229 Markdown: "# Pasta\n\n1. Boil pasta.",
230 Portions: 2,
231 }}
232 server := NewServer(backend, "test")
233
234 _, output, err := server.callPreviewRecipeTextTool(
235 context.Background(),
236 nil,
237 PreviewRecipeTextArguments{Title: " Pasta ", Text: " Boil pasta.\n"},
238 )
239 if err != nil {
240 t.Fatalf("callPreviewRecipeTextTool() error = %v", err)
241 }
242
243 if backend.previewCalls != 1 {
244 t.Fatalf("preview calls = %d, want 1", backend.previewCalls)
245 }
246 if backend.previewTitle != "Pasta" {
247 t.Fatalf("backend preview title = %q, want trimmed Pasta", backend.previewTitle)
248 }
249 if backend.previewText != " Boil pasta.\n" {
250 t.Fatalf("backend preview text = %q, want raw text preserved", backend.previewText)
251 }
252 if output.Title != "Pasta with Tomato Sauce" || output.Markdown != "# Pasta\n\n1. Boil pasta." ||
253 output.Portions != 2 {
254 t.Fatalf("preview output = %#v, want title/markdown/portions", output)
255 }
256}
257
258func TestCallToolACIDToolsPreviewRecipeTextTool1RequiresTitle(t *testing.T) {
259 backend := &fakeBackend{}
260 server := NewServer(backend, "test")
261
262 _, _, err := server.callPreviewRecipeTextTool(
263 context.Background(),
264 nil,
265 PreviewRecipeTextArguments{Title: " ", Text: "Boil pasta."},
266 )
267 if err == nil {
268 t.Fatal("callPreviewRecipeTextTool() error = nil, want missing title error")
269 }
270 if backend.previewCalls != 0 {
271 t.Fatalf("preview calls = %d, want none", backend.previewCalls)
272 }
273}
274
275func TestCallToolACIDToolsPreviewRecipeTextTool2RequiresText(t *testing.T) {
276 backend := &fakeBackend{}
277 server := NewServer(backend, "test")
278
279 _, _, err := server.callPreviewRecipeTextTool(
280 context.Background(),
281 nil,
282 PreviewRecipeTextArguments{Title: "Pasta", Text: " "},
283 )
284 if err == nil {
285 t.Fatal("callPreviewRecipeTextTool() error = nil, want missing text error")
286 }
287 if backend.previewCalls != 0 {
288 t.Fatalf("preview calls = %d, want none", backend.previewCalls)
289 }
290}
291
292func TestCallToolACIDRecipesSave2And9SavesPreparedRecipe(t *testing.T) {
293 backend := &fakeBackend{saveRecipeID: "recipe-1"}
294 server := NewServer(backend, "test")
295
296 _, output, err := server.callSaveRecipeTool(
297 context.Background(),
298 nil,
299 SaveRecipeArguments{
300 Source: " prepared ",
301 Title: " Pasta ",
302 Markdown: " # Pasta\n\n1. Boil pasta.\n",
303 Portions: 2,
304 },
305 )
306 if err != nil {
307 t.Fatalf("callSaveRecipeTool() error = %v", err)
308 }
309
310 if backend.saveCalls != 1 {
311 t.Fatalf("save calls = %d, want 1", backend.saveCalls)
312 }
313 if backend.saveTitle != "Pasta" {
314 t.Fatalf("backend save title = %q, want trimmed Pasta", backend.saveTitle)
315 }
316 if backend.saveMarkdown != " # Pasta\n\n1. Boil pasta.\n" {
317 t.Fatalf("backend save markdown = %q, want raw markdown preserved", backend.saveMarkdown)
318 }
319 if backend.savePortions != 2 {
320 t.Fatalf("backend save portions = %d, want 2", backend.savePortions)
321 }
322 if output.RecipeID != "recipe-1" {
323 t.Fatalf("save output recipe ID = %q, want recipe-1", output.RecipeID)
324 }
325}
326
327func TestCallToolACIDRecipesSave2_1To2_3RequiresPreparedFields(t *testing.T) {
328 tests := []struct {
329 name string
330 arguments SaveRecipeArguments
331 }{
332 {
333 name: "title",
334 arguments: SaveRecipeArguments{Source: "prepared", Title: " ", Markdown: "# Pasta", Portions: 2},
335 },
336 {
337 name: "markdown",
338 arguments: SaveRecipeArguments{Source: "prepared", Title: "Pasta", Markdown: " ", Portions: 2},
339 },
340 {
341 name: "portions",
342 arguments: SaveRecipeArguments{Source: "prepared", Title: "Pasta", Markdown: "# Pasta", Portions: 0},
343 },
344 }
345
346 for _, tt := range tests {
347 t.Run(tt.name, func(t *testing.T) {
348 backend := &fakeBackend{}
349 server := NewServer(backend, "test")
350
351 _, _, err := server.callSaveRecipeTool(context.Background(), nil, tt.arguments)
352 if err == nil {
353 t.Fatal("callSaveRecipeTool() error = nil, want missing prepared field error")
354 }
355 if backend.saveCalls != 0 {
356 t.Fatalf("save calls = %d, want none", backend.saveCalls)
357 }
358 })
359 }
360}
361
362func TestCallToolACIDRecipesSave10RejectsUnsupportedSourceBeforeCallingCooked(t *testing.T) {
363 backend := &fakeBackend{}
364 server := NewServer(backend, "test")
365
366 _, _, err := server.callSaveRecipeTool(context.Background(), nil, SaveRecipeArguments{Source: "url"})
367 if err == nil {
368 t.Fatal("callSaveRecipeTool() error = nil, want unsupported source error")
369 }
370 if backend.saveCalls != 0 {
371 t.Fatalf("save calls = %d, want none", backend.saveCalls)
372 }
373}
374
375func TestCallToolACIDRecipesSave1And11SavesRawTextRecipe(t *testing.T) {
376 backend := &fakeBackend{
377 preview: cooked.RecipeTextPreview{
378 Title: "Pasta with Tomato Sauce",
379 Markdown: "# Pasta\n\n1. Boil pasta.",
380 Portions: 2,
381 },
382 saveRecipeID: "recipe-1",
383 }
384 server := NewServer(backend, "test")
385
386 _, output, err := server.callSaveRecipeTool(
387 context.Background(),
388 nil,
389 SaveRecipeArguments{Source: " raw_text ", Title: " Pasta ", Text: " Boil pasta.\n"},
390 )
391 if err != nil {
392 t.Fatalf("callSaveRecipeTool() error = %v", err)
393 }
394
395 if backend.previewCalls != 1 || backend.saveCalls != 1 {
396 t.Fatalf("backend calls = preview %d save %d, want 1/1", backend.previewCalls, backend.saveCalls)
397 }
398 if backend.previewTitle != "Pasta" {
399 t.Fatalf("preview title = %q, want trimmed Pasta", backend.previewTitle)
400 }
401 if backend.previewText != " Boil pasta.\n" {
402 t.Fatalf("preview text = %q, want raw text preserved", backend.previewText)
403 }
404 if backend.saveTitle != "Pasta with Tomato Sauce" {
405 t.Fatalf("save title = %q, want preview title", backend.saveTitle)
406 }
407 if backend.saveMarkdown != "# Pasta\n\n1. Boil pasta." {
408 t.Fatalf("save markdown = %q, want preview markdown", backend.saveMarkdown)
409 }
410 if backend.savePortions != 2 {
411 t.Fatalf("save portions = %d, want preview portions 2", backend.savePortions)
412 }
413 if output.RecipeID != "recipe-1" {
414 t.Fatalf("save output recipe ID = %q, want recipe-1", output.RecipeID)
415 }
416}
417
418func TestCallToolACIDRecipesSave1_1To1_2RequiresRawTextFields(t *testing.T) {
419 tests := []struct {
420 name string
421 arguments SaveRecipeArguments
422 }{
423 {name: "title", arguments: SaveRecipeArguments{Source: "raw_text", Title: " ", Text: "Boil pasta."}},
424 {name: "text", arguments: SaveRecipeArguments{Source: "raw_text", Title: "Pasta", Text: " "}},
425 }
426
427 for _, tt := range tests {
428 t.Run(tt.name, func(t *testing.T) {
429 backend := &fakeBackend{}
430 server := NewServer(backend, "test")
431
432 _, _, err := server.callSaveRecipeTool(context.Background(), nil, tt.arguments)
433 if err == nil {
434 t.Fatal("callSaveRecipeTool() error = nil, want missing raw text field error")
435 }
436 if backend.previewCalls != 0 || backend.saveCalls != 0 {
437 t.Fatalf("backend calls = preview %d save %d, want none", backend.previewCalls, backend.saveCalls)
438 }
439 })
440 }
441}
442
443func TestCallToolACIDRecipesSave8And9UpdatesExistingRecipe(t *testing.T) {
444 backend := &fakeBackend{}
445 server := NewServer(backend, "test")
446
447 _, output, err := server.callSaveRecipeTool(
448 context.Background(),
449 nil,
450 SaveRecipeArguments{
451 Source: " existing ",
452 RecipeID: " recipe-1 ",
453 Markdown: " # Pasta\n\n1. Boil pasta.\n",
454 Portions: 4,
455 },
456 )
457 if err != nil {
458 t.Fatalf("callSaveRecipeTool() error = %v", err)
459 }
460
461 if backend.updateCalls != 1 {
462 t.Fatalf("update calls = %d, want 1", backend.updateCalls)
463 }
464 if backend.updateRecipeID != "recipe-1" {
465 t.Fatalf("backend update recipe ID = %q, want recipe-1", backend.updateRecipeID)
466 }
467 if backend.updateMarkdown != " # Pasta\n\n1. Boil pasta.\n" {
468 t.Fatalf("backend update markdown = %q, want raw markdown preserved", backend.updateMarkdown)
469 }
470 if backend.updatePortions != 4 {
471 t.Fatalf("backend update portions = %d, want 4", backend.updatePortions)
472 }
473 if output.RecipeID != "recipe-1" {
474 t.Fatalf("save output recipe ID = %q, want recipe-1", output.RecipeID)
475 }
476}
477
478func TestCallToolACIDRecipesSave8_1To8_3RequiresExistingFields(t *testing.T) {
479 tests := []struct {
480 name string
481 arguments SaveRecipeArguments
482 }{
483 {
484 name: "recipe ID",
485 arguments: SaveRecipeArguments{Source: "existing", RecipeID: " ", Markdown: "# Pasta", Portions: 4},
486 },
487 {
488 name: "markdown",
489 arguments: SaveRecipeArguments{Source: "existing", RecipeID: "recipe-1", Markdown: " ", Portions: 4},
490 },
491 {
492 name: "portions",
493 arguments: SaveRecipeArguments{Source: "existing", RecipeID: "recipe-1", Markdown: "# Pasta", Portions: 0},
494 },
495 }
496
497 for _, tt := range tests {
498 t.Run(tt.name, func(t *testing.T) {
499 backend := &fakeBackend{}
500 server := NewServer(backend, "test")
501
502 _, _, err := server.callSaveRecipeTool(context.Background(), nil, tt.arguments)
503 if err == nil {
504 t.Fatal("callSaveRecipeTool() error = nil, want missing existing field error")
505 }
506 if backend.updateCalls != 0 {
507 t.Fatalf("update calls = %d, want none", backend.updateCalls)
508 }
509 })
510 }
511}
512
513type fakeBackend struct {
514 shoppingList cooked.ShoppingList
515 recipes []cooked.RecipeCard
516 searchRecipes []cooked.RecipeCard
517 recipeMetadata cooked.RecipeMetadata
518 recipeContent cooked.RecipeContent
519 preview cooked.RecipeTextPreview
520 saveRecipeID string
521 page int
522 limit int
523 searchQuery string
524 searchPage int
525 metadataRecipeID string
526 contentRecipeID string
527 previewTitle string
528 previewText string
529 saveTitle string
530 saveMarkdown string
531 savePortions int
532 updateRecipeID string
533 updateMarkdown string
534 updatePortions int
535 metadataCalls int
536 contentCalls int
537 previewCalls int
538 saveCalls int
539 updateCalls int
540}
541
542func (f *fakeBackend) ReadShoppingList(context.Context) (cooked.ShoppingList, error) {
543 return f.shoppingList, nil
544}
545
546func (f *fakeBackend) ListRecipes(_ context.Context, page, limit int) ([]cooked.RecipeCard, error) {
547 f.page = page
548 f.limit = limit
549
550 return f.recipes, nil
551}
552
553func (f *fakeBackend) SearchRecipes(_ context.Context, query string, page int) ([]cooked.RecipeCard, error) {
554 f.searchQuery = query
555 f.searchPage = page
556
557 return f.searchRecipes, nil
558}
559
560func (f *fakeBackend) ReadRecipeMetadata(_ context.Context, recipeID string) (cooked.RecipeMetadata, error) {
561 f.metadataRecipeID = recipeID
562 f.metadataCalls++
563
564 return f.recipeMetadata, nil
565}
566
567func (f *fakeBackend) ReadRecipeContent(_ context.Context, recipeID string) (cooked.RecipeContent, error) {
568 f.contentRecipeID = recipeID
569 f.contentCalls++
570
571 return f.recipeContent, nil
572}
573
574func (f *fakeBackend) PreviewRecipeText(_ context.Context, title, text string) (cooked.RecipeTextPreview, error) {
575 f.previewTitle = title
576 f.previewText = text
577 f.previewCalls++
578
579 return f.preview, nil
580}
581
582func (f *fakeBackend) SavePreparedRecipe(_ context.Context, title, markdown string, portions int) (string, error) {
583 f.saveTitle = title
584 f.saveMarkdown = markdown
585 f.savePortions = portions
586 f.saveCalls++
587 if f.saveRecipeID != "" {
588 return f.saveRecipeID, nil
589 }
590
591 return "recipe-1", nil
592}
593
594func (f *fakeBackend) UpdateRecipeContent(_ context.Context, recipeID, markdown string, portions int) error {
595 f.updateRecipeID = recipeID
596 f.updateMarkdown = markdown
597 f.updatePortions = portions
598 f.updateCalls++
599
600 return nil
601}