bash.go

  1package tools
  2
  3import (
  4	"bytes"
  5	"cmp"
  6	"context"
  7	_ "embed"
  8	"fmt"
  9	"html/template"
 10	"os"
 11	"path/filepath"
 12	"runtime"
 13	"strings"
 14	"time"
 15
 16	"charm.land/fantasy"
 17	"github.com/charmbracelet/crush/internal/config"
 18	"github.com/charmbracelet/crush/internal/permission"
 19	"github.com/charmbracelet/crush/internal/shell"
 20)
 21
 22type BashParams struct {
 23	Description     string `json:"description" description:"A brief description of what the command does, try to keep it under 30 characters or so"`
 24	Command         string `json:"command" description:"The command to execute"`
 25	WorkingDir      string `json:"working_dir,omitempty" description:"The working directory to execute the command in (defaults to current directory)"`
 26	RunInBackground bool   `json:"run_in_background,omitempty" description:"Set to true (boolean) to run this command in the background. Use job_output to read the output later."`
 27}
 28
 29type BashPermissionsParams struct {
 30	Description     string `json:"description"`
 31	Command         string `json:"command"`
 32	WorkingDir      string `json:"working_dir"`
 33	RunInBackground bool   `json:"run_in_background"`
 34}
 35
 36type BashResponseMetadata struct {
 37	StartTime        int64  `json:"start_time"`
 38	EndTime          int64  `json:"end_time"`
 39	Output           string `json:"output"`
 40	Description      string `json:"description"`
 41	WorkingDirectory string `json:"working_directory"`
 42	Background       bool   `json:"background,omitempty"`
 43	ShellID          string `json:"shell_id,omitempty"`
 44}
 45
 46const (
 47	BashToolName = "bash"
 48
 49	AutoBackgroundThreshold = 1 * time.Minute // Commands taking longer automatically become background jobs
 50	MaxOutputLength         = 30000
 51	BashNoOutput            = "no output"
 52)
 53
 54//go:embed bash.tpl
 55var bashDescriptionTmpl []byte
 56
 57var bashDescriptionTpl = template.Must(
 58	template.New("bashDescription").
 59		Parse(string(bashDescriptionTmpl)),
 60)
 61
 62type bashDescriptionData struct {
 63	BannedCommands  string
 64	MaxOutputLength int
 65	Attribution     config.Attribution
 66	ModelName       string
 67}
 68
 69var bannedCommands = []string{
 70	// Network/Download tools
 71	"alias",
 72	"aria2c",
 73	"axel",
 74	"chrome",
 75	"curl",
 76	"curlie",
 77	"firefox",
 78	"http-prompt",
 79	"httpie",
 80	"links",
 81	"lynx",
 82	"nc",
 83	"safari",
 84	"scp",
 85	"ssh",
 86	"telnet",
 87	"w3m",
 88	"wget",
 89	"xh",
 90
 91	// System administration
 92	"doas",
 93	"su",
 94	"sudo",
 95
 96	// Package managers
 97	"apk",
 98	"apt",
 99	"apt-cache",
100	"apt-get",
101	"dnf",
102	"dpkg",
103	"emerge",
104	"home-manager",
105	"makepkg",
106	"opkg",
107	"pacman",
108	"paru",
109	"pkg",
110	"pkg_add",
111	"pkg_delete",
112	"portage",
113	"rpm",
114	"yay",
115	"yum",
116	"zypper",
117
118	// System modification
119	"at",
120	"batch",
121	"chkconfig",
122	"crontab",
123	"fdisk",
124	"mkfs",
125	"mount",
126	"parted",
127	"service",
128	"systemctl",
129	"umount",
130
131	// Network configuration
132	"firewall-cmd",
133	"ifconfig",
134	"ip",
135	"iptables",
136	"netstat",
137	"pfctl",
138	"route",
139	"ufw",
140}
141
142func bashDescription(attribution *config.Attribution, modelName string) string {
143	bannedCommandsStr := strings.Join(bannedCommands, ", ")
144	var out bytes.Buffer
145	if err := bashDescriptionTpl.Execute(&out, bashDescriptionData{
146		BannedCommands:  bannedCommandsStr,
147		MaxOutputLength: MaxOutputLength,
148		Attribution:     *attribution,
149		ModelName:       modelName,
150	}); err != nil {
151		// this should never happen.
152		panic("failed to execute bash description template: " + err.Error())
153	}
154	return out.String()
155}
156
157func blockFuncs() []shell.BlockFunc {
158	return []shell.BlockFunc{
159		shell.CommandsBlocker(bannedCommands),
160
161		// System package managers
162		shell.ArgumentsBlocker("apk", []string{"add"}, nil),
163		shell.ArgumentsBlocker("apt", []string{"install"}, nil),
164		shell.ArgumentsBlocker("apt-get", []string{"install"}, nil),
165		shell.ArgumentsBlocker("dnf", []string{"install"}, nil),
166		shell.ArgumentsBlocker("pacman", nil, []string{"-S"}),
167		shell.ArgumentsBlocker("pkg", []string{"install"}, nil),
168		shell.ArgumentsBlocker("yum", []string{"install"}, nil),
169		shell.ArgumentsBlocker("zypper", []string{"install"}, nil),
170
171		// Language-specific package managers
172		shell.ArgumentsBlocker("brew", []string{"install"}, nil),
173		shell.ArgumentsBlocker("cargo", []string{"install"}, nil),
174		shell.ArgumentsBlocker("gem", []string{"install"}, nil),
175		shell.ArgumentsBlocker("go", []string{"install"}, nil),
176		shell.ArgumentsBlocker("npm", []string{"install"}, []string{"--global"}),
177		shell.ArgumentsBlocker("npm", []string{"install"}, []string{"-g"}),
178		shell.ArgumentsBlocker("pip", []string{"install"}, []string{"--user"}),
179		shell.ArgumentsBlocker("pip3", []string{"install"}, []string{"--user"}),
180		shell.ArgumentsBlocker("pnpm", []string{"add"}, []string{"--global"}),
181		shell.ArgumentsBlocker("pnpm", []string{"add"}, []string{"-g"}),
182		shell.ArgumentsBlocker("yarn", []string{"global", "add"}, nil),
183
184		// `go test -exec` can run arbitrary commands
185		shell.ArgumentsBlocker("go", []string{"test"}, []string{"-exec"}),
186	}
187}
188
189func NewBashTool(permissions permission.Service, workingDir string, attribution *config.Attribution, modelName string) fantasy.AgentTool {
190	return fantasy.NewAgentTool(
191		BashToolName,
192		string(bashDescription(attribution, modelName)),
193		func(ctx context.Context, params BashParams, call fantasy.ToolCall) (fantasy.ToolResponse, error) {
194			if params.Command == "" {
195				return fantasy.NewTextErrorResponse("missing command"), nil
196			}
197
198			// Determine working directory
199			execWorkingDir := cmp.Or(params.WorkingDir, workingDir)
200
201			isSafeReadOnly := false
202			cmdLower := strings.ToLower(params.Command)
203
204			for _, safe := range safeCommands {
205				if strings.HasPrefix(cmdLower, safe) {
206					if len(cmdLower) == len(safe) || cmdLower[len(safe)] == ' ' || cmdLower[len(safe)] == '-' {
207						isSafeReadOnly = true
208						break
209					}
210				}
211			}
212
213			sessionID := GetSessionFromContext(ctx)
214			if sessionID == "" {
215				return fantasy.ToolResponse{}, fmt.Errorf("session ID is required for executing shell command")
216			}
217			var permResult permission.PermissionResult
218			if !isSafeReadOnly {
219				var err error
220				permResult, err = permissions.Request(ctx,
221					permission.CreatePermissionRequest{
222						SessionID:   sessionID,
223						Path:        execWorkingDir,
224						ToolCallID:  call.ID,
225						ToolName:    BashToolName,
226						Action:      "execute",
227						Description: fmt.Sprintf("Execute command: %s", params.Command),
228						Params:      BashPermissionsParams(params),
229					},
230				)
231				if err != nil {
232					return fantasy.ToolResponse{}, err
233				}
234				if !permResult.Granted {
235					if permResult.Message != "" {
236						return fantasy.NewTextErrorResponse("User denied permission." + permission.UserCommentaryTag(permResult.Message)), nil
237					}
238					return fantasy.ToolResponse{}, permission.ErrorPermissionDenied
239				}
240			}
241
242			// If explicitly requested as background, start immediately with detached context
243			if params.RunInBackground {
244				startTime := time.Now()
245				bgManager := shell.GetBackgroundShellManager()
246				bgManager.Cleanup()
247				// Use background context so it continues after tool returns
248				bgShell, err := bgManager.Start(context.Background(), execWorkingDir, blockFuncs(), params.Command, params.Description)
249				if err != nil {
250					return fantasy.ToolResponse{}, fmt.Errorf("error starting background shell: %w", err)
251				}
252
253				// Wait a short time to detect fast failures (blocked commands, syntax errors, etc.)
254				time.Sleep(1 * time.Second)
255				stdout, stderr, done, execErr := bgShell.GetOutput()
256
257				if done {
258					// Command failed or completed very quickly
259					bgManager.Remove(bgShell.ID)
260
261					interrupted := shell.IsInterrupt(execErr)
262					exitCode := shell.ExitCode(execErr)
263					if exitCode == 0 && !interrupted && execErr != nil {
264						return fantasy.ToolResponse{}, fmt.Errorf("[Job %s] error executing command: %w", bgShell.ID, execErr)
265					}
266
267					stdout = formatOutput(stdout, stderr, execErr)
268
269					metadata := BashResponseMetadata{
270						StartTime:        startTime.UnixMilli(),
271						EndTime:          time.Now().UnixMilli(),
272						Output:           stdout,
273						Description:      params.Description,
274						Background:       params.RunInBackground,
275						WorkingDirectory: bgShell.WorkingDir,
276					}
277					if stdout == "" {
278						return fantasy.WithResponseMetadata(fantasy.NewTextResponse(permResult.AppendCommentary(BashNoOutput)), metadata), nil
279					}
280					stdout += fmt.Sprintf("\n\n<cwd>%s</cwd>", normalizeWorkingDir(bgShell.WorkingDir))
281					return fantasy.WithResponseMetadata(fantasy.NewTextResponse(permResult.AppendCommentary(stdout)), metadata), nil
282				}
283
284				// Still running after fast-failure check - return as background job
285				metadata := BashResponseMetadata{
286					StartTime:        startTime.UnixMilli(),
287					EndTime:          time.Now().UnixMilli(),
288					Description:      params.Description,
289					WorkingDirectory: bgShell.WorkingDir,
290					Background:       true,
291					ShellID:          bgShell.ID,
292				}
293				response := fmt.Sprintf("Background shell started with ID: %s\n\nUse job_output tool to view output or job_kill to terminate.", bgShell.ID)
294				return fantasy.WithResponseMetadata(fantasy.NewTextResponse(permResult.AppendCommentary(response)), metadata), nil
295			}
296
297			// Start synchronous execution with auto-background support
298			startTime := time.Now()
299
300			// Start with detached context so it can survive if moved to background
301			bgManager := shell.GetBackgroundShellManager()
302			bgManager.Cleanup()
303			bgShell, err := bgManager.Start(context.Background(), execWorkingDir, blockFuncs(), params.Command, params.Description)
304			if err != nil {
305				return fantasy.ToolResponse{}, fmt.Errorf("error starting shell: %w", err)
306			}
307
308			// Wait for either completion, auto-background threshold, or context cancellation
309			ticker := time.NewTicker(100 * time.Millisecond)
310			defer ticker.Stop()
311			timeout := time.After(AutoBackgroundThreshold)
312
313			var stdout, stderr string
314			var done bool
315			var execErr error
316
317		waitLoop:
318			for {
319				select {
320				case <-ticker.C:
321					stdout, stderr, done, execErr = bgShell.GetOutput()
322					if done {
323						break waitLoop
324					}
325				case <-timeout:
326					stdout, stderr, done, execErr = bgShell.GetOutput()
327					break waitLoop
328				case <-ctx.Done():
329					// Incoming context was cancelled before we moved to background
330					// Kill the shell and return error
331					bgManager.Kill(bgShell.ID)
332					return fantasy.ToolResponse{}, ctx.Err()
333				}
334			}
335
336			if done {
337				// Command completed within threshold - return synchronously
338				// Remove from background manager since we're returning directly
339				// Don't call Kill() as it cancels the context and corrupts the exit code
340				bgManager.Remove(bgShell.ID)
341
342				interrupted := shell.IsInterrupt(execErr)
343				exitCode := shell.ExitCode(execErr)
344				if exitCode == 0 && !interrupted && execErr != nil {
345					return fantasy.ToolResponse{}, fmt.Errorf("[Job %s] error executing command: %w", bgShell.ID, execErr)
346				}
347
348				stdout = formatOutput(stdout, stderr, execErr)
349
350				metadata := BashResponseMetadata{
351					StartTime:        startTime.UnixMilli(),
352					EndTime:          time.Now().UnixMilli(),
353					Output:           stdout,
354					Description:      params.Description,
355					Background:       params.RunInBackground,
356					WorkingDirectory: bgShell.WorkingDir,
357				}
358				if stdout == "" {
359					return fantasy.WithResponseMetadata(fantasy.NewTextResponse(permResult.AppendCommentary(BashNoOutput)), metadata), nil
360				}
361				stdout += fmt.Sprintf("\n\n<cwd>%s</cwd>", normalizeWorkingDir(bgShell.WorkingDir))
362				return fantasy.WithResponseMetadata(fantasy.NewTextResponse(permResult.AppendCommentary(stdout)), metadata), nil
363			}
364
365			// Still running - keep as background job
366			metadata := BashResponseMetadata{
367				StartTime:        startTime.UnixMilli(),
368				EndTime:          time.Now().UnixMilli(),
369				Description:      params.Description,
370				WorkingDirectory: bgShell.WorkingDir,
371				Background:       true,
372				ShellID:          bgShell.ID,
373			}
374			response := fmt.Sprintf("Command is taking longer than expected and has been moved to background.\n\nBackground shell ID: %s\n\nUse job_output tool to view output or job_kill to terminate.", bgShell.ID)
375			return fantasy.WithResponseMetadata(fantasy.NewTextResponse(permResult.AppendCommentary(response)), metadata), nil
376		})
377}
378
379// formatOutput formats the output of a completed command with error handling
380func formatOutput(stdout, stderr string, execErr error) string {
381	interrupted := shell.IsInterrupt(execErr)
382	exitCode := shell.ExitCode(execErr)
383
384	stdout = truncateOutput(stdout)
385	stderr = truncateOutput(stderr)
386
387	errorMessage := stderr
388	if errorMessage == "" && execErr != nil {
389		errorMessage = execErr.Error()
390	}
391
392	if interrupted {
393		if errorMessage != "" {
394			errorMessage += "\n"
395		}
396		errorMessage += "Command was aborted before completion"
397	} else if exitCode != 0 {
398		if errorMessage != "" {
399			errorMessage += "\n"
400		}
401		errorMessage += fmt.Sprintf("Exit code %d", exitCode)
402	}
403
404	hasBothOutputs := stdout != "" && stderr != ""
405
406	if hasBothOutputs {
407		stdout += "\n"
408	}
409
410	if errorMessage != "" {
411		stdout += "\n" + errorMessage
412	}
413
414	return stdout
415}
416
417func truncateOutput(content string) string {
418	if len(content) <= MaxOutputLength {
419		return content
420	}
421
422	halfLength := MaxOutputLength / 2
423	start := content[:halfLength]
424	end := content[len(content)-halfLength:]
425
426	truncatedLinesCount := countLines(content[halfLength : len(content)-halfLength])
427	return fmt.Sprintf("%s\n\n... [%d lines truncated] ...\n\n%s", start, truncatedLinesCount, end)
428}
429
430func countLines(s string) int {
431	if s == "" {
432		return 0
433	}
434	return len(strings.Split(s, "\n"))
435}
436
437func normalizeWorkingDir(path string) string {
438	if runtime.GOOS == "windows" {
439		cwd, err := os.Getwd()
440		if err != nil {
441			cwd = "C:"
442		}
443		path = strings.ReplaceAll(path, filepath.VolumeName(cwd), "")
444	}
445
446	return filepath.ToSlash(path)
447}