chore: some small changes

Kujtim Hoxha created 1 month ago

Change summary

internal/agent/agent.go    |  1 -
internal/hooks/README.md   |  4 ++--
internal/hooks/builtins.go | 18 ++++++++++++------
3 files changed, 14 insertions(+), 9 deletions(-)

Detailed changes

internal/agent/agent.go

@@ -242,7 +242,6 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy
 				var assistantMsg message.Message
 				assistantMsg, err = a.messages.Create(callContext, call.SessionID, message.CreateMessageParams{
 					Role:     message.Assistant,
-					Parts:    []message.ContentPart{},
 					Model:    a.largeModel.ModelCfg.Model,
 					Provider: a.largeModel.ModelCfg.Provider,
 				})

internal/hooks/README.md

@@ -14,10 +14,10 @@ The hooks package provides a flexible, shell-based system for customizing Crush
 
 ### Cross-Platform Support
 
-The hooks system works on **Windows, macOS, and Linux**:
+The hooks system works on **Windows**, **macOS**, and **Linux**:
 
 - **Hook Files**: All hooks must be `.sh` files (shell scripts)
-- **Shell Execution**: Uses Crush's internal POSIX shell emulator (`mvdan.cc/sh`) on all platforms
+- **Shell Execution**: Uses Crush's internal POSIX shell emulator ([mvdan.cc/sh](https://mvdan.cc/sh)) on all platforms
 - **Hook Discovery**:
   - **Unix/macOS**: `.sh` files must have execute permission (`chmod +x hook.sh`)
   - **Windows**: `.sh` files are automatically recognized (no permission needed)

internal/hooks/builtins.go

@@ -15,7 +15,7 @@ func crushGetInput(ctx context.Context, args []string) error {
 	hc := interp.HandlerCtx(ctx)
 
 	if len(args) != 2 {
-		fmt.Fprintln(hc.Stderr, "Usage: crush_get_input <field_name>")
+		fmt.Fprintf(hc.Stderr, "Wrong number of arguments to `crush_get_input`. Expected 2, got %d.\n", len(args))
 		return interp.ExitStatus(1)
 	}
 
@@ -40,7 +40,7 @@ func crushGetInput(ctx context.Context, args []string) error {
 func crushGetToolInput(ctx context.Context, args []string) error {
 	hc := interp.HandlerCtx(ctx)
 	if len(args) != 2 {
-		fmt.Fprintln(hc.Stderr, "Usage: crush_get_tool_input <param_name>")
+		fmt.Fprintf(hc.Stderr, "Wrong number of arguments to `crush_get_tool_input`. Expected 2, got %d.\n", len(args))
 		return interp.ExitStatus(1)
 	}
 
@@ -70,6 +70,11 @@ func crushGetToolInput(ctx context.Context, args []string) error {
 func crushGetPrompt(ctx context.Context, args []string) error {
 	hc := interp.HandlerCtx(ctx)
 
+	if len(args) != 1 {
+		fmt.Fprintf(hc.Stderr, "Wrong number of arguments to `crush_get_prompt`. Expected 1, got %d.\n", len(args))
+		return interp.ExitStatus(1)
+	}
+
 	stdin := hc.Env.Get("_CRUSH_STDIN").Str
 
 	var data map[string]any
@@ -88,12 +93,13 @@ func crushGetPrompt(ctx context.Context, args []string) error {
 // crushLog writes a log message using slog.Debug.
 // Usage: crush_log "debug message"
 func crushLog(ctx context.Context, args []string) error {
-	if len(args) < 2 {
+	switch len(args) {
+	case 0, 1:
+		return nil
+	default:
+		slog.Debug(joinArgs(args[1:]))
 		return nil
 	}
-
-	slog.Debug(joinArgs(args[1:]))
-	return nil
 }
 
 // formatJSONValue converts a JSON value to a string suitable for shell output.