chore: fix broken performance tests:

Andrey Nering and Raphael Amorim created 4 months ago

Co-authored-by: Raphael Amorim <[e-mail]>

Change summary

internal/llm/tools/shell/comparison_test.go | 29 -----------------------
internal/llm/tools/shell/shell_test.go      | 25 -------------------
2 files changed, 54 deletions(-)

Detailed changes

internal/llm/tools/shell/comparison_test.go

@@ -3,7 +3,6 @@ package shell
 import (
 	"context"
 	"os"
-	"runtime"
 	"testing"
 	"time"
 
@@ -32,34 +31,6 @@ func TestShellPerformanceComparison(t *testing.T) {
 	t.Logf("Quick command took: %v", duration)
 }
 
-func TestShellCPUUsageComparison(t *testing.T) {
-	tmpDir, err := os.MkdirTemp("", "shell-test")
-	require.NoError(t, err)
-	defer os.RemoveAll(tmpDir)
-
-	shell := GetPersistentShell(tmpDir)
-	defer shell.Close()
-
-	// Measure CPU and memory usage during a longer command
-	var m1, m2 runtime.MemStats
-	runtime.GC()
-	runtime.ReadMemStats(&m1)
-
-	start := time.Now()
-	_, stderr, exitCode, _, err := shell.Exec(context.Background(), "sleep 0.1", 1000)
-	duration := time.Since(start)
-
-	runtime.ReadMemStats(&m2)
-
-	require.NoError(t, err)
-	assert.Equal(t, 0, exitCode)
-	assert.Empty(t, stderr)
-
-	memGrowth := m2.Alloc - m1.Alloc
-	t.Logf("Sleep 0.1s command took: %v", duration)
-	t.Logf("Memory growth during polling: %d bytes", memGrowth)
-	t.Logf("GC cycles during test: %d", m2.NumGC-m1.NumGC)
-}
 
 // Benchmark CPU usage during polling
 func BenchmarkShellPolling(b *testing.B) {

internal/llm/tools/shell/shell_test.go

@@ -4,35 +4,10 @@ import (
 	"context"
 	"os"
 	"testing"
-	"time"
 
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
-func TestShellPerformanceImprovement(t *testing.T) {
-	// Create a temporary directory for the shell
-	tmpDir, err := os.MkdirTemp("", "shell-test")
-	require.NoError(t, err)
-	defer os.RemoveAll(tmpDir)
-
-	shell := GetPersistentShell(tmpDir)
-	defer shell.Close()
-
-	// Test that quick commands complete fast
-	start := time.Now()
-	stdout, stderr, exitCode, _, err := shell.Exec(context.Background(), "echo 'hello world'", 0)
-	duration := time.Since(start)
-
-	require.NoError(t, err)
-	assert.Equal(t, 0, exitCode)
-	assert.Contains(t, stdout, "hello world")
-	assert.Empty(t, stderr)
-
-	// Quick commands should complete very fast with our exponential backoff
-	assert.Less(t, duration, 50*time.Millisecond, "Quick command should complete fast with exponential backoff")
-}
-
 // Benchmark to measure CPU efficiency
 func BenchmarkShellQuickCommands(b *testing.B) {
 	tmpDir, err := os.MkdirTemp("", "shell-bench")