From 87a483cc24696b0c23edddbcd39c8ae244888bbd Mon Sep 17 00:00:00 2001 From: Charm <124303983+charmcli@users.noreply.github.com> Date: Mon, 4 Aug 2025 09:16:26 -0300 Subject: [PATCH 1/3] chore(legal): @Ed4ward has signed the CLA --- .github/cla-signatures.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/cla-signatures.json b/.github/cla-signatures.json index f2a774e00890cc5d2059133563c44664862fcbd6..fd1813da29531a5ed0aa5f9c2886bf7bfb303de6 100644 --- a/.github/cla-signatures.json +++ b/.github/cla-signatures.json @@ -207,6 +207,14 @@ "created_at": "2025-08-03T21:35:15Z", "repoId": 987670088, "pullRequestNo": 527 + }, + { + "name": "Ed4ward", + "id": 153800328, + "comment_id": 3150375016, + "created_at": "2025-08-04T12:16:16Z", + "repoId": 987670088, + "pullRequestNo": 539 } ] } \ No newline at end of file From 054fba302914e64a36ce58e80d615df82f92267a Mon Sep 17 00:00:00 2001 From: Charm <124303983+charmcli@users.noreply.github.com> Date: Mon, 4 Aug 2025 11:01:45 -0300 Subject: [PATCH 2/3] chore(legal): @ngnhng has signed the CLA --- .github/cla-signatures.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/cla-signatures.json b/.github/cla-signatures.json index fd1813da29531a5ed0aa5f9c2886bf7bfb303de6..0b2aa1335dadaefee2b547c3d85278006c4425f4 100644 --- a/.github/cla-signatures.json +++ b/.github/cla-signatures.json @@ -215,6 +215,14 @@ "created_at": "2025-08-04T12:16:16Z", "repoId": 987670088, "pullRequestNo": 539 + }, + { + "name": "ngnhng", + "id": 51743767, + "comment_id": 3150846779, + "created_at": "2025-08-04T14:01:30Z", + "repoId": 987670088, + "pullRequestNo": 546 } ] } \ No newline at end of file From 87ee7dfa77f871b5c31ef5e8d9940b05bd03c7bf Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Mon, 4 Aug 2025 11:54:55 -0300 Subject: [PATCH 3/3] fix(mcp): update lib, set transport logger (#510) --- go.mod | 2 +- go.sum | 4 ++-- internal/llm/agent/mcp-tools.go | 11 ++++++++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/go.mod b/go.mod index 82b89a581d7bbd35698ed5f555ad0e1b324b9ff4..7e41d27cb2c2b8c7382ebfefaeab5188c5dc1e67 100644 --- a/go.mod +++ b/go.mod @@ -27,7 +27,7 @@ require ( github.com/google/uuid v1.6.0 github.com/invopop/jsonschema v0.13.0 github.com/joho/godotenv v1.5.1 - github.com/mark3labs/mcp-go v0.34.0 + github.com/mark3labs/mcp-go v0.36.0 github.com/muesli/termenv v0.16.0 github.com/ncruces/go-sqlite3 v0.25.0 github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646 diff --git a/go.sum b/go.sum index c223c37700b6b9f3f3fc0fb6c537c734bab63ac7..37c3c7ed4509a19f5732262c904cf01ad329a51b 100644 --- a/go.sum +++ b/go.sum @@ -180,8 +180,8 @@ github.com/lucasb-eyer/go-colorful v1.2.0 h1:1nnpGOrhyZZuNyfu1QjKiUICQ74+3FNCN69 github.com/lucasb-eyer/go-colorful v1.2.0/go.mod h1:R4dSotOR9KMtayYi1e77YzuveK+i7ruzyGqttikkLy0= github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0= github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc= -github.com/mark3labs/mcp-go v0.34.0 h1:eWy7WBGvhk6EyAAyVzivTCprE52iXJwNtvHV6Cv3bR0= -github.com/mark3labs/mcp-go v0.34.0/go.mod h1:rXqOudj/djTORU/ThxYx8fqEVj/5pvTuuebQ2RC7uk4= +github.com/mark3labs/mcp-go v0.36.0 h1:rIZaijrRYPeSbJG8/qNDe0hWlGrCJ7FWHNMz2SQpTis= +github.com/mark3labs/mcp-go v0.36.0/go.mod h1:T7tUa2jO6MavG+3P25Oy/jR7iCeJPHImCZHRymCn39g= github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY= github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= github.com/mattn/go-runewidth v0.0.16 h1:E5ScNMtiwvlvB5paMFdw9p4kSQzbXFikJ5SQO6TULQc= diff --git a/internal/llm/agent/mcp-tools.go b/internal/llm/agent/mcp-tools.go index 97f00c92d156b5d50c2a6a84d1f853a0db1246aa..8df78e52452385a44a06fd07feb62d3b9892388f 100644 --- a/internal/llm/agent/mcp-tools.go +++ b/internal/llm/agent/mcp-tools.go @@ -11,10 +11,8 @@ import ( "github.com/charmbracelet/crush/internal/config" "github.com/charmbracelet/crush/internal/csync" "github.com/charmbracelet/crush/internal/llm/tools" - "github.com/charmbracelet/crush/internal/version" - "github.com/charmbracelet/crush/internal/permission" - + "github.com/charmbracelet/crush/internal/version" "github.com/mark3labs/mcp-go/client" "github.com/mark3labs/mcp-go/client/transport" "github.com/mark3labs/mcp-go/mcp" @@ -191,6 +189,7 @@ func createMcpClient(m config.MCPConfig) (*client.Client, error) { return client.NewStreamableHttpClient( m.URL, transport.WithHTTPHeaders(m.ResolvedHeaders()), + transport.WithLogger(mcpHTTPLogger{}), ) case config.MCPSse: return client.NewSSEMCPClient( @@ -201,3 +200,9 @@ func createMcpClient(m config.MCPConfig) (*client.Client, error) { return nil, fmt.Errorf("unsupported mcp type: %s", m.Type) } } + +// for MCP's HTTP client. +type mcpHTTPLogger struct{} + +func (l mcpHTTPLogger) Errorf(format string, v ...any) { slog.Error(fmt.Sprintf(format, v...)) } +func (l mcpHTTPLogger) Infof(format string, v ...any) { slog.Info(fmt.Sprintf(format, v...)) }