fix: simplify

Carlos Alexandro Becker created 3 months ago

Signed-off-by: Carlos Alexandro Becker <[e-mail]>

Change summary

internal/agent/coordinator.go      | 4 ++--
internal/agent/coordinator_test.go | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)

Detailed changes

internal/agent/coordinator.go

@@ -851,17 +851,17 @@ func (c *coordinator) RecoverSession(ctx context.Context, sessionID string) erro
 	}
 
 	for _, msg := range msgs {
-		if msg.IsFinished() || msg.Role == message.Assistant {
+		if msg.IsFinished() {
 			continue
 		}
 
+		msg.FinishThinking()
 		for _, tc := range msg.ToolCalls() {
 			if !tc.Finished {
 				msg.FinishToolCall(tc.ID)
 			}
 		}
 
-		msg.FinishThinking()
 		msg.AddFinish(message.FinishReasonError, "Session interrupted", "The session was previously interrupted")
 		if updateErr := c.messages.Update(ctx, msg); updateErr != nil {
 			slog.Error("Failed to recover message", "message_id", msg.ID, "error", updateErr)

internal/agent/coordinator_test.go

@@ -93,7 +93,7 @@ func TestRecoverSession(t *testing.T) {
 		require.NoError(t, err)
 		require.True(t, recoveredMsg.IsFinished())
 		require.Equal(t, message.FinishReasonError, recoveredMsg.FinishReason())
-		require.Contains(t, recoveredMsg.FinishPart().Message, "Summarization interrupted")
+		require.Contains(t, recoveredMsg.FinishPart().Message, "Session interrupted")
 	})
 
 	t.Run("incomplete assistant message with tool calls", func(t *testing.T) {
@@ -136,7 +136,7 @@ func TestRecoverSession(t *testing.T) {
 		require.NoError(t, err)
 		require.True(t, recoveredMsg.IsFinished())
 		require.Equal(t, message.FinishReasonError, recoveredMsg.FinishReason())
-		require.Contains(t, recoveredMsg.FinishPart().Message, "Response interrupted")
+		require.Contains(t, recoveredMsg.FinishPart().Message, "Session interrupted")
 
 		// Verify the tool call was marked as finished
 		toolCalls := recoveredMsg.ToolCalls()
@@ -175,7 +175,7 @@ func TestRecoverSession(t *testing.T) {
 		require.NoError(t, err)
 		require.True(t, recoveredMsg.IsFinished())
 		require.Equal(t, message.FinishReasonError, recoveredMsg.FinishReason())
-		require.Contains(t, recoveredMsg.FinishPart().Message, "Response interrupted")
+		require.Contains(t, recoveredMsg.FinishPart().Message, "Session interrupted")
 		require.Equal(t, "This is a partial response...", recoveredMsg.Content().Text)
 	})