fix(lsp): improve auto discovery (#2086)

Carlos Alexandro Becker created 1 week ago

- ignore .git for autodiscovery
- ignore LSPs with only .git as root marker

Signed-off-by: Carlos Alexandro Becker <[e-mail]>

Change summary

internal/lsp/client.go | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

Detailed changes

internal/lsp/client.go

@@ -591,12 +591,17 @@ func FilterMatching(dir string, servers map[string]*powernapconfig.ServerConfig)
 	}
 	normalized := make(map[string]serverPatterns, len(servers))
 	for name, server := range servers {
-		if len(server.RootMarkers) == 0 {
-			continue
+		var patterns []string
+		for _, p := range server.RootMarkers {
+			if p == ".git" {
+				// ignore .git for discovery
+				continue
+			}
+			patterns = append(patterns, filepath.ToSlash(p))
 		}
-		patterns := make([]string, len(server.RootMarkers))
-		for i, p := range server.RootMarkers {
-			patterns[i] = filepath.ToSlash(p)
+		if len(patterns) == 0 {
+			slog.Debug("ignoring lsp with no root markers", "name", name)
+			continue
 		}
 		normalized[name] = serverPatterns{server: server, patterns: patterns}
 	}