From a3ddd48c9919b99a30a0c0cf80cd51d02fd2b817 Mon Sep 17 00:00:00 2001 From: tauraamui Date: Mon, 8 Dec 2025 15:37:29 +0000 Subject: [PATCH] chore: rename unit test titles to better reflect reality --- internal/agent/tools/bash_test.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/internal/agent/tools/bash_test.go b/internal/agent/tools/bash_test.go index 24d9bce981491b126cf30bac2dd5204862daeba7..64491bb04eefb317c5743241e81fb30b00978d0a 100644 --- a/internal/agent/tools/bash_test.go +++ b/internal/agent/tools/bash_test.go @@ -8,7 +8,7 @@ import ( "github.com/stretchr/testify/require" ) -func TestResolveBlockFuncsFromEmptyConfig(t *testing.T) { +func TestResolveBannedCommandsListWithEmptyConfig(t *testing.T) { cfg := config.ToolBash{ DisableDefaultCommands: false, BannedCommands: []string{}, @@ -20,7 +20,7 @@ func TestResolveBlockFuncsFromEmptyConfig(t *testing.T) { assert.Equal(t, defaultBannedCommands, bannedCmds) } -func TestResolveBlockFuncsFromEmptyConfigWithDefaultDisabled(t *testing.T) { +func TestResolveBannedCommandsListWithEmptyConfigWithDefaultDisabled(t *testing.T) { cfg := config.ToolBash{ DisableDefaultCommands: true, BannedCommands: []string{}, @@ -32,7 +32,7 @@ func TestResolveBlockFuncsFromEmptyConfigWithDefaultDisabled(t *testing.T) { assert.Equal(t, []string{}, bannedCmds) } -func TestResolveBlockFuncsDefaultDisabledWithBannedCommands(t *testing.T) { +func TestResolveBannedCommandsListWithDefaultDisabledWithBannedCommands(t *testing.T) { cfg := config.ToolBash{ DisableDefaultCommands: true, BannedCommands: []string{ @@ -47,7 +47,7 @@ func TestResolveBlockFuncsDefaultDisabledWithBannedCommands(t *testing.T) { assert.Equal(t, []string{"pacman", "mount"}, bannedCmds) } -func TestResolveBlockFuncsWithDefaultAndAddtionalBannedCommands(t *testing.T) { +func TestResolveBannedCommandsListWithDefaultAndAddtionalBannedCommands(t *testing.T) { additionalBannedCommands := []string{"lazygit", "btop"} cfg := config.ToolBash{ DisableDefaultCommands: false, @@ -58,3 +58,6 @@ func TestResolveBlockFuncsWithDefaultAndAddtionalBannedCommands(t *testing.T) { bannedCmds := resolveBannedCommandsList(cfg) require.Len(t, bannedCmds, len(defaultBannedCommands)+len(additionalBannedCommands)) } + +func TestResolveBlockFuncsWithDefaultDisabledSubCommands(t *testing.T) { +}