From a5f18aa02bc275df525c895d71dceb4a0a47284f Mon Sep 17 00:00:00 2001 From: Ayman Bagabas Date: Thu, 25 Sep 2025 16:09:43 -0400 Subject: [PATCH] refactor(config): simplify environment variable resolution --- internal/config/resolve.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/internal/config/resolve.go b/internal/config/resolve.go index 6eb6cc5d8b14ec0c3b1d465662cc39eb97d4fdf8..47a73e7acfed465038af778b395bae16a415b7e7 100644 --- a/internal/config/resolve.go +++ b/internal/config/resolve.go @@ -3,6 +3,7 @@ package config import ( "context" "fmt" + "os" "strings" "time" @@ -163,14 +164,5 @@ func NewEnvironmentVariableResolver(env []string) VariableResolver { // ResolveValue resolves environment variables from the provided env.Env. func (r *environmentVariableResolver) ResolveValue(value string) (string, error) { - if !strings.HasPrefix(value, "$") { - return value, nil - } - - varName := strings.TrimPrefix(value, "$") - resolvedValue := environ(r.env).Getenv(varName) - if resolvedValue == "" { - return "", fmt.Errorf("environment variable %q not set", varName) - } - return resolvedValue, nil + return os.Expand(value, environ(r.env).Getenv), nil }