fix(tools): do not truncate output (#657)

Carlos Alexandro Becker created 2 months ago

This may cause more problems than it fixes, as for instance, it cuts
json responses as well, rendering them invalid.

Signed-off-by: Carlos Alexandro Becker <[e-mail]>

Change summary

internal/llm/tools/tools.go | 75 --------------------------------------
1 file changed, 1 insertion(+), 74 deletions(-)

Detailed changes

internal/llm/tools/tools.go

@@ -3,8 +3,6 @@ package tools
 import (
 	"context"
 	"encoding/json"
-	"fmt"
-	"strings"
 )
 
 type ToolInfo struct {
@@ -27,10 +25,6 @@ const (
 
 	SessionIDContextKey sessionIDContextKey = "session_id"
 	MessageIDContextKey messageIDContextKey = "message_id"
-
-	maxResponseWidth  = 3000
-	maxResponseHeight = 5000
-	maxResponseChars  = 50000
 )
 
 type ToolResponse struct {
@@ -43,75 +37,8 @@ type ToolResponse struct {
 func NewTextResponse(content string) ToolResponse {
 	return ToolResponse{
 		Type:    ToolResponseTypeText,
-		Content: truncateContent(content),
-	}
-}
-
-func truncateContent(content string) string {
-	if len(content) <= maxResponseChars {
-		return truncateWidthAndHeight(content)
-	}
-
-	truncated := content[:maxResponseChars]
-
-	if lastNewline := strings.LastIndex(truncated, "\n"); lastNewline > maxResponseChars/2 {
-		truncated = truncated[:lastNewline]
-	}
-
-	truncated += "\n\n... [Content truncated due to length] ..."
-
-	return truncateWidthAndHeight(truncated)
-}
-
-func truncateWidthAndHeight(content string) string {
-	lines := strings.Split(content, "\n")
-
-	heightTruncated := false
-	if len(lines) > maxResponseHeight {
-		keepLines := maxResponseHeight - 3
-		firstHalf := keepLines / 2
-		secondHalf := keepLines - firstHalf
-
-		truncatedLines := make([]string, 0, maxResponseHeight)
-		truncatedLines = append(truncatedLines, lines[:firstHalf]...)
-		truncatedLines = append(truncatedLines, "")
-		truncatedLines = append(truncatedLines, fmt.Sprintf("... [%d lines truncated] ...", len(lines)-keepLines))
-		truncatedLines = append(truncatedLines, "")
-		truncatedLines = append(truncatedLines, lines[len(lines)-secondHalf:]...)
-
-		lines = truncatedLines
-		heightTruncated = true
-	}
-
-	widthTruncated := false
-	for i, line := range lines {
-		if len(line) > maxResponseWidth {
-			if maxResponseWidth > 20 {
-				keepChars := maxResponseWidth - 10
-				firstHalf := keepChars / 2
-				secondHalf := keepChars - firstHalf
-				lines[i] = line[:firstHalf] + " ... " + line[len(line)-secondHalf:]
-			} else {
-				lines[i] = line[:maxResponseWidth]
-			}
-			widthTruncated = true
-		}
-	}
-
-	result := strings.Join(lines, "\n")
-
-	if heightTruncated || widthTruncated {
-		notices := make([]string, 0, 2)
-		if heightTruncated {
-			notices = append(notices, "height")
-		}
-		if widthTruncated {
-			notices = append(notices, "width")
-		}
-		result += fmt.Sprintf("\n\n[Note: Content truncated by %s to fit response limits]", strings.Join(notices, " and "))
+		Content: content,
 	}
-
-	return result
 }
 
 func WithResponseMetadata(response ToolResponse, metadata any) ToolResponse {