From e18a77f5df5dc99ff5f5677d4281733e1f90ade5 Mon Sep 17 00:00:00 2001
From: Kujtim Hoxha <kujtimii.h@gmail.com>
Date: Fri, 25 Jul 2025 15:58:02 +0200
Subject: [PATCH] chore: small fix

---
 internal/tui/exp/list/list.go                 | 17 +++-------------
 ...are_at_the_bottom_in_backwards_list.golden | 20 +++++++++----------
 ...d_we_are_at_the_top_in_forward_list.golden |  4 ++--
 3 files changed, 15 insertions(+), 26 deletions(-)

diff --git a/internal/tui/exp/list/list.go b/internal/tui/exp/list/list.go
index 1970abb3ea925715fe01d74358d0e89c1a637fb7..3af90d405382ba5df207774c4f2fba109717034a 100644
--- a/internal/tui/exp/list/list.go
+++ b/internal/tui/exp/list/list.go
@@ -746,20 +746,16 @@ func (l *list[T]) GetSize() (int, int) {
 
 // GoToBottom implements List.
 func (l *list[T]) GoToBottom() tea.Cmd {
-	if l.offset != 0 {
-		l.selectedItem = ""
-	}
 	l.offset = 0
+	l.selectedItem = ""
 	l.direction = DirectionBackward
 	return l.render()
 }
 
 // GoToTop implements List.
 func (l *list[T]) GoToTop() tea.Cmd {
-	if l.offset != 0 {
-		l.selectedItem = ""
-	}
 	l.offset = 0
+	l.selectedItem = ""
 	l.direction = DirectionForward
 	return l.render()
 }
@@ -996,14 +992,7 @@ func (l *list[T]) UpdateItem(id string, item T) tea.Cmd {
 		if hasOldItem && l.direction == DirectionBackward {
 			// if we are the last item and there is no offset
 			// make sure to go to the bottom
-			if inx == l.items.Len()-1 && l.offset == 0 {
-				cmd = l.GoToBottom()
-				if cmd != nil {
-					cmds = append(cmds, cmd)
-				}
-
-				// if the item is at least partially below the viewport
-			} else if oldPosition < oldItem.end {
+			if oldPosition < oldItem.end {
 				newItem, ok := l.renderedItems.Get(item.ID())
 				if ok {
 					newLines := newItem.height - oldItem.height
diff --git a/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_appended_and_we_are_at_the_bottom_in_backwards_list.golden b/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_appended_and_we_are_at_the_bottom_in_backwards_list.golden
index 9166c3d388f45243860fde6827b42196305d84ea..8cea66d71fb8e43fc9e0ac8fcb6ee1000cfcb5e4 100644
--- a/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_appended_and_we_are_at_the_bottom_in_backwards_list.golden
+++ b/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_appended_and_we_are_at_the_bottom_in_backwards_list.golden
@@ -1,10 +1,10 @@
-│Item 29  
-│Item 29  
-│Item 29  
-│Item 29  
-│Item 29  
-│Item 29  
-│Item 29  
-│Item 29  
-│Item 29  
-Testing   
\ No newline at end of file
+Item 29   
+Item 29   
+Item 29   
+Item 29   
+Item 29   
+Item 29   
+Item 29   
+Item 29   
+Item 29   
+│Testing  
\ No newline at end of file
diff --git a/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_prepended_and_we_are_at_the_top_in_forward_list.golden b/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_prepended_and_we_are_at_the_top_in_forward_list.golden
index 5493247c7713c227dc5a46ea5422c2b8c10a492e..faed253a104304630e9e33decc445622cde8739a 100644
--- a/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_prepended_and_we_are_at_the_top_in_forward_list.golden
+++ b/internal/tui/exp/list/testdata/TestListMovement/should_not_change_offset_when_new_items_are_prepended_and_we_are_at_the_top_in_forward_list.golden
@@ -1,5 +1,5 @@
-Testing   
-│Item 0   
+│Testing  
+Item 0    
 Item 1    
 Item 1    
 Item 2