From f6b2203355f8c509004a956e37ceae4024a6a70d Mon Sep 17 00:00:00 2001
From: Christian Rocha <christian@rocha.is>
Date: Tue, 14 Apr 2026 10:52:25 -0400
Subject: [PATCH] fix: tests, swagger doc comments

---
 internal/server/proto.go         | 15 +++++++++------
 internal/session/session_test.go |  2 +-
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/internal/server/proto.go b/internal/server/proto.go
index f87bf84ea954ee81773561040e1143d20a50e3b3..01635406e80324971ce20cf663e94b3a04c8198a 100644
--- a/internal/server/proto.go
+++ b/internal/server/proto.go
@@ -461,14 +461,19 @@ func (c *controllerV1) handleDeleteWorkspaceSession(w http.ResponseWriter, r *ht
 	w.WriteHeader(http.StatusOK)
 }
 
+// updateSessionModelsRequest is the request body for updating session models.
+type updateSessionModelsRequest struct {
+	Models map[config.SelectedModelType]config.SelectedModel `json:"models"`
+}
+
 // handlePostWorkspaceSessionModels updates the models for a session.
 //
 //	@Summary		Update session models
 //	@Tags			sessions
 //	@Accept			json
-//	@Param			id		path		string										true	"Workspace ID"
-//	@Param			sid		path		string										true	"Session ID"
-//	@Param			body	body		object	true	"Models"	example({"models":{"large":{"model":"gpt-4o","provider":"openai"}}})
+//	@Param			id		path		string							true	"Workspace ID"
+//	@Param			sid		path		string							true	"Session ID"
+//	@Param			body	body		updateSessionModelsRequest	true	"Models"
 //	@Success		204
 //	@Failure		400	{object}	proto.Error
 //	@Failure		500	{object}	proto.Error
@@ -477,9 +482,7 @@ func (c *controllerV1) handlePostWorkspaceSessionModels(w http.ResponseWriter, r
 	workspaceID := r.PathValue("id")
 	sessionID := r.PathValue("sid")
 
-	var req struct {
-		Models map[config.SelectedModelType]config.SelectedModel `json:"models"`
-	}
+	var req updateSessionModelsRequest
 	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
 		c.server.logError(r, "Failed to decode request", "error", err)
 		jsonError(w, http.StatusBadRequest, "failed to decode request")
diff --git a/internal/session/session_test.go b/internal/session/session_test.go
index c8f06795006081e7a05750fd6970b2d79076819f..82928b208d091c168de3782dd1128d9e5e51d377 100644
--- a/internal/session/session_test.go
+++ b/internal/session/session_test.go
@@ -114,7 +114,7 @@ func TestFromDBItemWithModels(t *testing.T) {
 	t.Run("empty models", func(t *testing.T) {
 		t.Parallel()
 		item := testDBSession()
-		item.Models = sql.NullString{String: "", Valid: false}
+		item.Models = sql.NullString{String: "", Valid: true}
 		result := service{}.fromDBItem(item)
 		require.Nil(t, result.Models)
 	})