From 15d1db54507e3a1d8cae9d538a0b9b56b201afd9 Mon Sep 17 00:00:00 2001 From: Amolith Date: Fri, 31 Oct 2025 16:21:38 -0600 Subject: [PATCH] fix(permission): prevent race in concurrent test Co-authored-by: Crush --- internal/permission/permission_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/permission/permission_test.go b/internal/permission/permission_test.go index e36700771af6968bb780c39be4ca91cbbe92baa5..387759844416830e691a5142bffd0def5d90c350 100644 --- a/internal/permission/permission_test.go +++ b/internal/permission/permission_test.go @@ -188,7 +188,6 @@ func TestPermissionService_SequentialProperties(t *testing.T) { events := service.Subscribe(t.Context()) var wg sync.WaitGroup - results := make([]bool, 0) requests := []CreatePermissionRequest{ { @@ -214,11 +213,13 @@ func TestPermissionService_SequentialProperties(t *testing.T) { }, } + results := make([]bool, len(requests)) + for i, req := range requests { wg.Add(1) go func(index int, request CreatePermissionRequest) { defer wg.Done() - results = append(results, service.Request(request)) + results[index] = service.Request(request) }(i, req) }