From 88c88c65059f0c4821c84680bbb940ce356040ee Mon Sep 17 00:00:00 2001 From: Amolith Date: Mon, 3 Nov 2025 10:04:54 -0700 Subject: [PATCH] refactor(agent): clarify user-initiated cancellations and denials (#1368) Co-authored-by: Crush --- internal/agent/agent.go | 6 +++--- internal/permission/permission.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/agent/agent.go b/internal/agent/agent.go index 5a70195ce8e3bd1cbb06af3ce8be50e6b3a2c58e..7023e386eca2b07e8c5f9293fc9d5be86c8f6849 100644 --- a/internal/agent/agent.go +++ b/internal/agent/agent.go @@ -427,7 +427,7 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy if isCancelErr { content = "Tool execution canceled by user" } else if isPermissionErr { - content = "Permission denied" + content = "User denied permission" } toolResult := message.ToolResult{ ToolCallID: tc.ID, @@ -446,9 +446,9 @@ func (a *sessionAgent) Run(ctx context.Context, call SessionAgentCall) (*fantasy } } if isCancelErr { - currentAssistant.AddFinish(message.FinishReasonCanceled, "Request cancelled", "") + currentAssistant.AddFinish(message.FinishReasonCanceled, "User canceled request", "") } else if isPermissionErr { - currentAssistant.AddFinish(message.FinishReasonPermissionDenied, "Permission denied", "") + currentAssistant.AddFinish(message.FinishReasonPermissionDenied, "User denied permission", "") } else { currentAssistant.AddFinish(message.FinishReasonError, "API Error", err.Error()) } diff --git a/internal/permission/permission.go b/internal/permission/permission.go index 77b2526a592d0d194f75fb71af05477ae75df80b..e7bc3f65f22fd6a0df396816c77150355e36fca6 100644 --- a/internal/permission/permission.go +++ b/internal/permission/permission.go @@ -13,7 +13,7 @@ import ( "github.com/google/uuid" ) -var ErrorPermissionDenied = errors.New("permission denied") +var ErrorPermissionDenied = errors.New("user denied permission") type CreatePermissionRequest struct { SessionID string `json:"session_id"`