chore: run `modernize` (#906)

Andrey Nering created 3 months ago

Change summary

internal/app/app.go                    |  6 ++----
internal/app/lsp_events.go             |  7 ++-----
internal/csync/slices.go               |  6 ++----
internal/permission/permission_test.go | 12 ++++--------
4 files changed, 10 insertions(+), 21 deletions(-)

Detailed changes

internal/app/app.go

@@ -235,9 +235,7 @@ func setupSubscriber[T any](
 	subscriber func(context.Context) <-chan pubsub.Event[T],
 	outputCh chan<- tea.Msg,
 ) {
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		subCh := subscriber(ctx)
 		for {
 			select {
@@ -260,7 +258,7 @@ func setupSubscriber[T any](
 				return
 			}
 		}
-	}()
+	})
 }
 
 func (app *App) InitCoderAgent() error {

internal/app/lsp_events.go

@@ -2,6 +2,7 @@ package app
 
 import (
 	"context"
+	"maps"
 	"time"
 
 	"github.com/charmbracelet/crush/internal/csync"
@@ -48,11 +49,7 @@ func SubscribeLSPEvents(ctx context.Context) <-chan pubsub.Event[LSPEvent] {
 
 // GetLSPStates returns the current state of all LSP clients
 func GetLSPStates() map[string]LSPClientInfo {
-	states := make(map[string]LSPClientInfo)
-	for name, info := range lspStates.Seq2() {
-		states[name] = info
-	}
-	return states
+	return maps.Collect(lspStates.Seq2())
 }
 
 // GetLSPState returns the state of a specific LSP client

internal/csync/slices.go

@@ -16,11 +16,9 @@ type LazySlice[K any] struct {
 // to populate it.
 func NewLazySlice[K any](load func() []K) *LazySlice[K] {
 	s := &LazySlice[K]{}
-	s.wg.Add(1)
-	go func() {
+	s.wg.Go(func() {
 		s.inner = load()
-		s.wg.Done()
-	}()
+	})
 	return s
 }
 

internal/permission/permission_test.go

@@ -154,12 +154,10 @@ func TestPermissionService_SequentialProperties(t *testing.T) {
 		events := service.Subscribe(t.Context())
 		var result1 bool
 		var wg sync.WaitGroup
-		wg.Add(1)
 
-		go func() {
-			defer wg.Done()
+		wg.Go(func() {
 			result1 = service.Request(req)
-		}()
+		})
 
 		var permissionReq PermissionRequest
 		event := <-events
@@ -170,12 +168,10 @@ func TestPermissionService_SequentialProperties(t *testing.T) {
 		assert.True(t, result1, "First request should be granted")
 
 		var result2 bool
-		wg.Add(1)
 
-		go func() {
-			defer wg.Done()
+		wg.Go(func() {
 			result2 = service.Request(req)
-		}()
+		})
 
 		event = <-events
 		permissionReq = event.Payload