Correct behaviour of nameExists()

Amolith created 3 years ago

Change summary

createHandler.go | 4 ++--
helperfuncs.go   | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

Detailed changes

createHandler.go

@@ -28,11 +28,11 @@ func (m *model) createHandler(writer http.ResponseWriter, request *http.Request)
 	name := query.Get("name")
 	if len(name) == 0 {
 		name = uniuri.NewLen(4)
-		for !m.nameExists(name) {
+		for m.nameExists(name) {
 			name = uniuri.NewLen(4)
 			log.Println("Generated new name:", name)
 		}
-	} else if !m.nameExists(name) {
+	} else if m.nameExists(name) {
 		http.Error(writer, "406 Not Acceptable: A shortened URL with this name already exists", 406)
 		return
 	}

helperfuncs.go

@@ -42,7 +42,7 @@ func (m model) nameExists(name string) bool {
 		}
 		return nil
 	})
-	if err != nil {
+	if err == nil {
 		return true
 	}
 	return false