Labels: area/comments kind/feature lifecycle/stale priority/awaiting-more-evidence triage/needs-information
For now, comments are rendered in the CLI and termUI as pure text. It would be neat to have markdown instead.
While it's easy to find a renderer that output HTML, finding one that render as text or even better text formatted with terminal escape sequence is more tricky.
Need some investigation.
You can combine these two libraries to get what you want:
Looks like there are 2 Go implementations of CommonMark. I couldn’t find anything in Go to convert Markdown to ANSI codes, but I did find this Node library. Alternatively, since Markdown tries to be human-readable, it could be output as-is on terminals. Support could eventually be added to style bold/italics as they’re supposed to be styled while fading out the */_ delimiters. Similar things could be done for inline code (fade out the `) and code blocks (fade out the ``` and syntax-highlight the code based on the language tag).
We would also like Markdown comments.
For extra credit: it would be nice to have a markdown 'templating' way to dynamically render meta-data variables (like $issue_id, $issue_labels, $issue_title, $issue_status).
I started working on this:
It's in the termui-markdown branch, but not bolted in the termui yet.
With #150, we now have markdown rendering in the webUI. Thanks @sandhose !
@ProgramFan I currently writing a Markdown renderer for the terminal. This renderer use the util/text that you rewrote to fix my broken code. Ideally, this renderer would be integrated upstream to the blackfriday project, but this require to re-license your code as well. Would you agree to re license it to the MIT license ?
No problem with MIT.
@ProgramFan I published the text package as a standalone package here: https://github.com/MichaelMure/go-term-text
Nice to see that :smile:
Michael Muré notifications@github.com 于2019年7月15日周一 上午8:06写道：
@ProgramFan https://github.com/ProgramFan I published the text package as a standalone package here: https://github.com/MichaelMure/go-term-text
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MichaelMure/git-bug/issues/12?email_source=notifications&email_token=AAAH5DHYICCC4G6MEPBDTCLP7O5PVA5CNFSM4FPKJVQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4QAIQ#issuecomment-511246370, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH5DG7XE63TPWWPLAEPPLP7O5PVANCNFSM4FPKJVQQ .
FYI, this is still happening over at https://github.com/MichaelMure/go-term-markdown. It needs a little bit more work but it's getting close.
This bot triages untriaged issues and PRs according to the following rules:
lifecycle/stale label is appliedlifecycle/stale was applied, the issue is closedTo remove the stale status, you can:
lifecycle/stale label
sudoforge removed label enhancement
sudoforge removed label RFC
sudoforge removed label lifecycle/stale
sudoforge added label kind/feature
sudoforge added label area/comments
sudoforge added label triage/needs-priority
sudoforge added label triage/needs-information
sudoforge removed label triage/needs-priority
sudoforge added label priority/awaiting-more-evidence
This bot triages issues in order to help the maintainers identify what needs attention, according to the following lifecycle rules:
lifecycle/stale is appliedlifecycle/stale was applied,
lifecycle/rotten is appliedThis bot will not automatically close stale issues.
To remove the stale status, you can:
To avoid automatic lifecycle management of this issue, add
lifecycle/frozen.