It would be neat to support comment edition or removal. A few notes:

• require two new Operations
• as the data model is immutable, it would not fully erase the previous comment version. While it would not be visible in the UI anymore, it would still be readable through the bug history.
• in bug.Snapshot, a proper Timeline needs to be implemented and would replace the current usage of Operations. This Timeline would hold the data that is expected to be displayed in a UI, instead of the raw stream of events

Michael Muré (MichaelMure) added label enhancement 7 years ago

Michael Muré (MichaelMure) added label Core 7 years ago

Alright, with https://github.com/MichaelMure/git-bug/pull/54 the core is mostly ready for comment edition.

• each operations can now be back referenced with their hash
• add a new EditCommentOperation that edit a previous comment (including the initial comment yield by the CreateOperation)
• the Snapshot now hold a Timeline in addition the the raw array of Operation, providing a processed view of the history, ready for each UI to use. In particular, comments now hold their edit history

Left for later: there is no check that the author is allowed to edit the comment. We need crypto signature for that ...

With https://github.com/MichaelMure/git-bug/pull/60, @adamslc made the comments editable in the termUI.

Comment edition command coming in #424

This has been working for long.

Michael Muré (MichaelMure) closed the bug 3 years ago

sudoforge removed label enhancement 2 years ago

sudoforge removed label Core 2 years ago

sudoforge added label kind/feature 2 years ago

sudoforge added label area/comments 2 years ago