I just tried git-bug today, and the github bridge helped set up authentication for a private repository. But I got this email, and it looks like bad news:

On October 28th, 2020 at 15:24 (UTC) you or an application you used recently accessed the deprecated Authorizations endpoint on the GitHub API with the useragent Go-http-client/1.1.

We will remove the Authorizations API endpoint on November 13, 2020. If you accessed the API via password authentication, then we recommend you use the web flow to authenticate. Please check that your app uses the web flow for authentication https://docs.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#web-application-flow

You can learn more about these changes by visiting our developer blog https://github.blog/2020-07-30-token-authentication-requirements-for-api-and-git-operations/

Sorry to be the bearer!

Yeah, that's no fun.

My understanding is that git-bug need to implement the following flow: https://docs.github.com/en/free-pro-team@latest/developers/apps/authorizing-oauth-apps#device-flow

That seems doable with a limited scope of changes. Any takers?

Michael Muré (MichaelMure) added label area/bridge 5 years ago

Michael Muré (MichaelMure) changed the title from [github] Auth endpoint is being EOL november 13 to [github] Auth endpoint is being deprecated 5 years ago

Michael Muré (MichaelMure) changed the title from [github] Auth endpoint is being deprecated to [github] Auth endpoint is being EOL november 13 5 years ago

Current flow is over here: https://github.com/MichaelMure/git-bug/blob/master/bridge/github/config.go#L172-L366

Michael Muré (MichaelMure) added label Easy pick 5 years ago

I would like to take the issue. (I will probably need more than two or three days to produce a reasonable pull request, though.)

Yes please!

It seems like we need to have a client_id from Github in order to user their OAuth authorization (as described in https://docs.github.com/en/free-pro-team@latest/developers/apps/authorizing-oauth-apps#device-flow).

@MichaelMure: Do you have one? If not, do you want to register an app for the git-bug organization as descirbed at https://docs.github.com/en/free-pro-team@latest/developers/apps/creating-an-oauth-app ?

I don't have one, but I'll make one.

Any idea what I should have as Authorization callback URL ?

Alright, I set that url to http://example.com. I believe it's not useful for the device flow. I also opted in for the device flow.

Client Id is ce3600aa56c2e69f18a5.

That said, you might want to create an app on your account while you develop that thing, so you can see what is hapenning.

Thanks

Fixed with #496 :tada: . The annoying thing though is that we can't release a new version at the moment.

Michael Muré (MichaelMure) closed the bug 5 years ago