feat: Link to code from comment on specific line of code

Labels: area/comments kind/feature lifecycle/stale priority/awaiting-more-evidence triage/needs-approval

Timeline

Tanguy â§“ Herrmann (dolanor) opened

Hi,

I really liked parts of git-appraise and I also like the approach of git-bug. One thing I miss from git-appraise is the ability to attach a comment to a file + line. That would make git-bug a good code review tool on top of an issue tracker.

Michael Muré (MichaelMure) commented

Hey Tanguy :)

There is two way I can think of something like this:

  1. having git-bug parse something like path/to/file.go:234 in comments and allow to either display the source code in the webui or open an editor from the termui
  2. have a full blown pull-request/code review support

Number two is something I would like to see at some point. I hadn't think about number one but it could be neat. It's also kind of a subset of what is needed to accomplish number two. Both are quite a lot of work though, it most likely won't happen anytime soon.

Tanguy â§“ Herrmann (dolanor) commented

Ok. I'll keep using git-appraise for that need then in the meantime. And if ever that so desired "free time" comes to me, I might try to help add it :)

Michael Muré (MichaelMure) commented

That'd be awesome.

Michael Muré (MichaelMure) changed the title from feat: Link to code from comment on specific line of code to Contextual comment on specific line of code ... or code review ?

Michael Muré (MichaelMure) added label Core

Michael Muré (MichaelMure) added label enhancement

Michael Muré (MichaelMure) changed the title from Contextual comment on specific line of code ... or code review ? to [feat] Link to code from comment on specific line of code

Michael Muré (MichaelMure) changed the title from [feat] Link to code from comment on specific line of code to feat: Link to code from comment on specific line of code

github-actions (github-actions) commented

This bot triages untriaged issues and PRs according to the following rules:

  • After 90 days of inactivity, the lifecycle/stale label is applied
  • After 30 days of inactivity since lifecycle/stale was applied, the issue is closed

To remove the stale status, you can:

  • Remove the lifecycle/stale label
  • Comment on this issue

github-actions (github-actions) added label lifecycle/stale

sudoforge added label kind/feature

sudoforge added label priority/awaiting-more-evidence

sudoforge added label area/comments

sudoforge added label triage/needs-approval

sudoforge removed label lifecycle/stale

sudoforge removed label enhancement

sudoforge removed label Core

github-actions (github-actions) commented

This bot triages issues in order to help the maintainers identify what needs attention, according to the following lifecycle rules:

  • After 90 days of inactivity, lifecycle/stale is applied
  • After 90 days of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

This bot will not automatically close stale issues.

To remove the stale status, you can:

  • Remove the stale label from this issue
  • Comment on this issue
  • Close this issue
  • Offer to help out with triaging

To avoid automatic lifecycle management of this issue, add lifecycle/frozen.

github-actions (github-actions) added label lifecycle/stale

Michael Muré (MichaelMure) commented

Not stale

On Fri, Nov 1, 2024, 4:29 AM github-actions[bot] @.***> wrote:

This bot triages issues in order to help the maintainers identify what needs attention, according to the following lifecycle rules:

  • After 90 days of inactivity, lifecycle/stale is applied
  • After 90 days of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

This bot will not automatically close stale issues.

To remove the stale status, you can:

  • Remove the stale label from this issue
  • Comment on this issue
  • Close this issue
  • Offer to help out with triaging

To avoid automatic lifecycle management of this issue, add lifecycle/frozen.

— Reply to this email directly, view it on GitHub https://github.com/git-bug/git-bug/issues/215#issuecomment-2451225583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACH6DP6YTWTXD4MW3PPKWTZ6LYSDAVCNFSM6AAAAABLJPUUEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRGIZDKNJYGM . You are receiving this because you commented.Message ID: @.***>

github-actions (github-actions) removed label lifecycle/idle