This is a really cool project.

The next step for me would be to support branch reviews with discussions to replace merge requests. Do you have any plans for this?

The rough features needed would be:

• multi-user discussions on changesets within files
• marking a change as "needs improvements"
• Resolving discussions and improvement requests
• Marking a commit as approved

ps: I'm happy to help out with this if you see this within the project scope.

I just discovered https://github.com/google/git-appraise, which is pretty what this would be.

Depending on the storage model etc it could either make sense to re-implement this or possibly to have an integration with git-appraise. Especially on the UI part.

So one approach could be to add a git-appraise view in the webui.

In SIT, we're just including git format-patch files into issues to do merge requests and discussions can go on there. We don't have a way to comment on specific lines, but this is just a matter of designating some kind of referencing convention for comment records.

Maybe this can be of some use/inspiration here?

In SIT, we're just including git format-patch files into issues to do merge requests

@yrashk, did you have CI/CD and automate the enforcement of constraints such as required minimum number of approvals? If so, how?

Closing as duplicate of #373

Michael Muré (MichaelMure) closed the bug 3 years ago