github bridge to shared (not owned) repository panics on "comment id not found"

Labels: lifecycle/rotten

alefminus (alefminus) opened 3 years ago

I have a private repository that my user has access to via invite, i.e.

while I am user "user".

git bug push / pull works as expected, since it is just using git which works.

But using git bug bridge push (I have tested the same token on another repository and verified it works with git bug bridge pull/push) I get:

❯ git bug bridge push
panic: unexpected error: comment id not found

goroutine 22 [running]:
github.com/MichaelMure/git-bug/bridge/github.(*githubExporter).exportBug(0xc0000a8a50, {0x12c5b38, 0xc0003c4200}, 0xc0003102d0, 0x0?)
        /home/alon/src/git-bug/bridge/github/export.go:345 +0x2265
github.com/MichaelMure/git-bug/bridge/github.(*githubExporter).ExportAll.func1()
        /home/alon/src/git-bug/bridge/github/export.go:188 +0x527
created by github.com/MichaelMure/git-bug/bridge/github.(*githubExporter).ExportAll
        /home/alon/src/git-bug/bridge/github/export.go:146 +0x2a5

Using built from source (a00f1a98972239c4a57cc126e9b41e6c4c53b023)

Is this use case supported? is it even possible to support it, i.e. does github allow persona tokens of user to edit issues on a repo owned by owner?

Thanks, Alon

Michael Muré (MichaelMure) commented 3 years ago

This is the line where it happens: https://github.com/MichaelMure/git-bug/blob/247e1a865db29a3189acfd89cde776a52a7ebaac/bridge/github/export.go#L345

This is likely a bug in git-bug introduced when Comments got an interleaved id (https://github.com/MichaelMure/git-bug/blob/master/entity/id_interleaved.go), that hold both the bug Id and the comment Id. It's quite weird that the automated test don't catch it though ..

alefminus (alefminus) commented 3 years ago

Thanks. I verified it is still present in 0.7.1-717-gdd8134b6 (git describe --tags), stack trace unchanged. Any pointers to trying to fix it? (on the low probability I manage to find the time)

Michael Muré (MichaelMure) commented 3 years ago

Would you mind checking if that bug is still present in the last v0.8.0 release?

github-actions (github-actions) commented 1 year ago

This bot triages untriaged issues and PRs according to the following rules:

After 90 days of inactivity, the lifecycle/stale label is applied
After 30 days of inactivity since lifecycle/stale was applied, the issue is closed

To remove the stale status, you can:

Remove the lifecycle/stale label
Comment on this issue

github-actions (github-actions) added label lifecycle/stale 1 year ago

github-actions (github-actions) commented 11 months ago

This bot triages issues in order to help the maintainers identify what needs attention, according to the following lifecycle rules:

After 90 days of inactivity, lifecycle/stale is applied
After 90 days of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

This bot will not automatically close stale issues.

To remove the stale status, you can:

Remove the stale label from this issue
Comment on this issue
Close this issue
Offer to help out with triaging

To avoid automatic lifecycle management of this issue, add lifecycle/frozen.

github-actions (github-actions) added label lifecycle/rotten 11 months ago

github-actions (github-actions) removed label lifecycle/stale 11 months ago

sudoforge removed label lifecycle/dormant 7 months ago

Timeline