style: resolve PR comments

Steve Moyer created 2 years ago

Change summary

commands/bug/bug_label_new.go | 4 +---
commands/bug/bug_label_rm.go  | 4 +---
commands/bug/bug_show.go      | 2 --
commands/bug/completion.go    | 4 ++--
4 files changed, 4 insertions(+), 10 deletions(-)

Detailed changes

commands/bug/bug_label_new.go

@@ -22,13 +22,11 @@ func newBugLabelNewCommand(env *execenv.Env) *cobra.Command {
 }
 
 func runBugLabelNew(env *execenv.Env, args []string) error {
-	b, args, err := ResolveSelected(env.Backend, args)
+	b, added, err := ResolveSelected(env.Backend, args)
 	if err != nil {
 		return err
 	}
 
-	added := args
-
 	changes, _, err := b.ChangeLabels(text.CleanupOneLineArray(added), nil)
 
 	for _, change := range changes {

commands/bug/bug_label_rm.go

@@ -22,13 +22,11 @@ func newBugLabelRmCommand(env *execenv.Env) *cobra.Command {
 }
 
 func runBugLabelRm(env *execenv.Env, args []string) error {
-	b, args, err := ResolveSelected(env.Backend, args)
+	b, removed, err := ResolveSelected(env.Backend, args)
 	if err != nil {
 		return err
 	}
 
-	removed := args
-
 	changes, _, err := b.ChangeLabels(nil, text.CleanupOneLineArray(removed))
 
 	for _, change := range changes {

commands/bug/bug_show.go

@@ -91,8 +91,6 @@ func runBugShow(env *execenv.Env, opts bugShowOptions, args []string) error {
 		case "title":
 			env.Out.Printf("%s\n", snap.Title)
 		default:
-			env.Out.Println()
-
 			return fmt.Errorf("unsupported field: %s", opts.fields)
 		}
 

commands/bug/completion.go

@@ -50,7 +50,7 @@ func BugAndLabelsCompletion(env *execenv.Env, addOrRemove bool) completion.Valid
 			_ = env.Backend.Close()
 		}()
 
-		b, args, err := ResolveSelected(env.Backend, args)
+		b, cleanArgs, err := ResolveSelected(env.Backend, args)
 		if _select.IsErrNoValidId(err) {
 			// we need a bug first to complete labels
 			return bugWithBackend(env.Backend, toComplete)
@@ -62,7 +62,7 @@ func BugAndLabelsCompletion(env *execenv.Env, addOrRemove bool) completion.Valid
 		snap := b.Snapshot()
 
 		seenLabels := map[bug.Label]bool{}
-		for _, label := range args {
+		for _, label := range cleanArgs {
 			seenLabels[bug.Label(label)] = addOrRemove
 		}