Fix bugs and cleanup code

vince created 5 years ago

Change summary

cache/repo_cache.go     | 4 ++--
cache/repo_cache_bug.go | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

Detailed changes

cache/repo_cache.go

@@ -22,7 +22,7 @@ import (
 const formatVersion = 2
 
 // The maximum number of bugs loaded in memory. After that, eviction will be done.
-const defaultMaxLoadedBugs = 100
+const defaultMaxLoadedBugs = 1000
 
 var _ repository.RepoCommon = &RepoCache{}
 
@@ -160,7 +160,7 @@ func (c *RepoCache) Close() error {
 
 	c.identities = make(map[entity.Id]*IdentityCache)
 	c.identitiesExcerpts = nil
-	c.bugs = nil
+	c.bugs = make(map[entity.Id]*BugCache)
 	c.bugExcerpts = nil
 
 	lockPath := repoLockFilePath(c.repo)

cache/repo_cache_bug.go

@@ -119,7 +119,7 @@ func (c *RepoCache) ResolveBugExcerpt(id entity.Id) (*BugExcerpt, error) {
 
 	excerpt, ok := c.bugExcerpts[id]
 	if !ok {
-		panic("missing bug in the cache")
+		return nil, bug.ErrBugNotExist
 	}
 
 	return excerpt, nil