docs(commands): try to make cleaned argument use more obvious

Steve Moyer created 2 years ago

Change summary

commands/bug/bug_comment_test.go | 1 -
commands/bug/bug_label_new.go    | 4 +++-
commands/bug/bug_label_rm.go     | 4 +++-
3 files changed, 6 insertions(+), 3 deletions(-)

Detailed changes

commands/bug/bug_comment_test.go

@@ -140,7 +140,6 @@ func requireCommentsEqual(t *testing.T, golden string, env *execenv.Env) {
 	comments = normalizeParsedComments(t, comments)
 
 	if *cmdtest.Update {
-		t.Log("Got here")
 		for i, comment := range comments {
 			fileName := fmt.Sprintf(goldenFilePattern, golden, i)
 			require.NoError(t, os.WriteFile(fileName, []byte(comment.message), 0644))

commands/bug/bug_label_new.go

@@ -22,11 +22,13 @@ func newBugLabelNewCommand(env *execenv.Env) *cobra.Command {
 }
 
 func runBugLabelNew(env *execenv.Env, args []string) error {
-	b, added, err := ResolveSelected(env.Backend, args)
+	b, cleanArgs, err := ResolveSelected(env.Backend, args)
 	if err != nil {
 		return err
 	}
 
+	added := cleanArgs
+
 	changes, _, err := b.ChangeLabels(text.CleanupOneLineArray(added), nil)
 
 	for _, change := range changes {

commands/bug/bug_label_rm.go

@@ -22,11 +22,13 @@ func newBugLabelRmCommand(env *execenv.Env) *cobra.Command {
 }
 
 func runBugLabelRm(env *execenv.Env, args []string) error {
-	b, removed, err := ResolveSelected(env.Backend, args)
+	b, cleanArgs, err := ResolveSelected(env.Backend, args)
 	if err != nil {
 		return err
 	}
 
+	removed := cleanArgs
+
 	changes, _, err := b.ChangeLabels(nil, text.CleanupOneLineArray(removed))
 
 	for _, change := range changes {