Add warning messages for launchpad-preview

Amine Hilaly created 6 years ago

fix --target flag description
improve comments

Change summary

bridge/github/config.go      | 6 +++---
bridge/launchpad/config.go   | 7 +++++++
commands/bridge_configure.go | 2 +-
3 files changed, 11 insertions(+), 4 deletions(-)

Detailed changes

bridge/github/config.go

@@ -44,12 +44,12 @@ func (*Github) Configure(repo repository.RepoCommon, params core.BridgeParams) (
 
 	// getting owner and project name
 	if params.Owner != "" && params.Project != "" {
-		// first try to use params if they are both provided
+		// first try to use params if both or project and owner are provided
 		owner = params.Owner
 		project = params.Project
 
 	} else if params.URL != "" {
-		// try to parse them from params URL
+		// try to parse params URL and extract owner and project
 		_, owner, project, err = splitURL(params.URL)
 		if err != nil {
 			return nil, err
@@ -62,7 +62,7 @@ func (*Github) Configure(repo repository.RepoCommon, params core.BridgeParams) (
 			return nil, err
 		}
 
-		// try terminal prompt
+		// terminal prompt
 		owner, project, err = promptURL(remotes)
 		if err != nil {
 			return nil, err

bridge/launchpad/config.go

@@ -19,6 +19,13 @@ var (
 )
 
 func (*Launchpad) Configure(repo repository.RepoCommon, params core.BridgeParams) (core.Configuration, error) {
+	if params.Token != "" {
+		fmt.Println("warn: token is not needed to configure a launchpad-preview bridge")
+	}
+	if params.Owner != "" {
+		fmt.Println("warn: owner is not used when configuring a launchpad-preview bridge")
+	}
+
 	conf := make(core.Configuration)
 	var err error
 	var project string

commands/bridge_configure.go

@@ -114,7 +114,7 @@ var bridgeConfigureCmd = &cobra.Command{
 func init() {
 	bridgeCmd.AddCommand(bridgeConfigureCmd)
 	bridgeConfigureCmd.Flags().StringVarP(&name, "name", "n", "", "Bridge name")
-	bridgeConfigureCmd.Flags().StringVarP(&target, "target", "t", "", "Bridge target name. Valid values are [github,gitlab,gitea,launchpad]")
+	bridgeConfigureCmd.Flags().StringVarP(&target, "target", "t", "", "Bridge target name. Valid values are [github,gitlab,gitea,launchpad-preview]")
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.URL, "url", "u", "", "Repository url")
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Owner, "owner", "o", "", "Repository owner")
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Token, "token", "T", "", "Authentication token")