Simplified show commadn error handling.

Sebastien Devaux created 6 years ago

Exit on first unknown field found in query.

Change summary

commands/show.go | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

Detailed changes

commands/show.go

@@ -83,8 +83,6 @@ func runShowBug(cmd *cobra.Command, args []string) error {
 			)
 		}
 	} else {
-		unknownFields:=""
-		err:=false
 		for _, field := range showFieldsQuery {
 			switch field {
 				case "author": fmt.Printf("%s ",firstComment.Author.DisplayName())
@@ -98,14 +96,10 @@ func runShowBug(cmd *cobra.Command, args []string) error {
 				case "status": fmt.Printf("%s ",snapshot.Status)
 				case "title": fmt.Printf("%s ",snapshot.Title)
 				default:
-					unknownFields+=field+" "
-					err=true
+					return fmt.Errorf("\nUnsupported field: %s\n",field)
 			}
 		}
 		fmt.Printf("\n")
-		if err {
-			return fmt.Errorf("Unsupported fields requested: %s\n",unknownFields)
-		}
 	}
 
 	return nil