commands: enhance flag description

Amine and Michael Muré created 6 years ago

bridge/github: improve configuration logic

Co-Authored-By: Michael Muré <[e-mail]>

Change summary

bridge/github/config.go      | 2 +-
commands/bridge_configure.go | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Detailed changes

bridge/github/config.go

@@ -45,7 +45,7 @@ func (g *Github) Configure(repo repository.RepoCommon, params core.BridgeParams)
 	var project string
 
 	if params.Token != "" &&
-		!(params.URL != "" || (params.Project != "" && params.Owner != "")) {
+		(params.URL == "" && (params.Project == "" || params.Owner == "")) {
 		return nil, fmt.Errorf("you must provide a project URL or Owner/Name to configure this bridge with a token")
 	}
 

commands/bridge_configure.go

@@ -191,7 +191,7 @@ func init() {
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.URL, "url", "u", "", "The URL of the target repository")
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Owner, "owner", "o", "", "The owner of the target repository")
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Token, "token", "T", "", "The authentication token for the API")
-	bridgeConfigureCmd.Flags().BoolVar(&tokenStdin, "token-stdin", false, "Expect to receive token from stdin and ignore token flag.")
+	bridgeConfigureCmd.Flags().BoolVar(&tokenStdin, "token-stdin", false, "Will read the token from stdin and ignore --token")
 	bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Project, "project", "p", "", "The name of the target repository")
 	bridgeConfigureCmd.Flags().SortFlags = false
 }