Merge pull request #272 from MichaelMure/fix-import-time-save

Amine created 5 years ago

bridge: fix incorrect last import time on context cancel

Change summary

bridge/github/import.go |  2 +-
commands/bridge_pull.go | 18 ++++++++++++++----
2 files changed, 15 insertions(+), 5 deletions(-)

Detailed changes

bridge/github/import.go

@@ -78,7 +78,7 @@ func (gi *githubImporter) ImportAll(ctx context.Context, repo *cache.RepoCache,
 			}
 		}
 
-		if err := gi.iterator.Error(); err != nil && err != context.Canceled {
+		if err := gi.iterator.Error(); err != nil {
 			gi.out <- core.NewImportError(err, "")
 		}
 	}()

commands/bridge_pull.go

@@ -96,15 +96,25 @@ func runBridgePull(cmd *cobra.Command, args []string) error {
 	importedIssues := 0
 	importedIdentities := 0
 	for result := range events {
-		if result.Event != core.ImportEventNothing {
-			fmt.Println(result.String())
-		}
-
 		switch result.Event {
+		case core.ImportEventNothing:
+			// filtered
+
 		case core.ImportEventBug:
 			importedIssues++
+			fmt.Println(result.String())
+
 		case core.ImportEventIdentity:
 			importedIdentities++
+			fmt.Println(result.String())
+
+		case core.ImportEventError:
+			if result.Err != context.Canceled {
+				fmt.Println(result.String())
+			}
+
+		default:
+			fmt.Println(result.String())
 		}
 	}