test(809): remove reliance on repo's filesystem

Steve Moyer created 3 years ago

Change summary

commands/add_test.go         | 10 +++++-----
commands/env_testing.go      |  3 ---
commands/rm_test.go          |  2 +-
commands/user_create_test.go | 16 +++++++++-------
4 files changed, 15 insertions(+), 16 deletions(-)

Detailed changes

commands/add_test.go

@@ -7,10 +7,10 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func newTestEnvUserAndBug(t *testing.T) (*testEnv, string, string) {
+func newTestEnvAndBug(t *testing.T) (*testEnv, string) {
 	t.Helper()
 
-	testEnv, userID := newTestEnvAndUser(t)
+	testEnv, _ := newTestEnvAndUser(t)
 	opts := addOptions{
 		title:          "this is a bug title",
 		message:        "this is a bug message",
@@ -23,10 +23,10 @@ func newTestEnvUserAndBug(t *testing.T) (*testEnv, string, string) {
 	bugID := strings.Split(testEnv.out.String(), " ")[0]
 	testEnv.out.Reset()
 
-	return testEnv, userID, bugID
+	return testEnv, bugID
 }
 
 func TestAdd(t *testing.T) {
-	_, _, user := newTestEnvUserAndBug(t)
-	require.Regexp(t, "^[0-9A-Fa-f]{7}$", user)
+	_, bugID := newTestEnvAndBug(t)
+	require.Regexp(t, "^[0-9A-Fa-f]{7}$", bugID)
 }

commands/env_testing.go

@@ -12,7 +12,6 @@ import (
 
 type testEnv struct {
 	env *Env
-	cwd string
 	out *bytes.Buffer
 }
 
@@ -20,7 +19,6 @@ func newTestEnv(t *testing.T) *testEnv {
 	t.Helper()
 
 	repo := repository.CreateGoGitTestRepo(t, false)
-	cwd := repository.RepoDir(t, repo)
 
 	buf := new(bytes.Buffer)
 
@@ -37,7 +35,6 @@ func newTestEnv(t *testing.T) *testEnv {
 			out:     out{Writer: buf},
 			err:     out{Writer: buf},
 		},
-		cwd: cwd,
 		out: buf,
 	}
 }

commands/rm_test.go

@@ -7,7 +7,7 @@ import (
 )
 
 func TestRm(t *testing.T) {
-	testEnv, _, bugID := newTestEnvUserAndBug(t)
+	testEnv, bugID := newTestEnvAndBug(t)
 
 	exp := "bug " + bugID + " removed\n"
 

commands/user_create_test.go

@@ -1,21 +1,25 @@
 package commands
 
 import (
-	"path/filepath"
 	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 )
 
+const (
+	testUserName  = "John Doe"
+	testUserEmail = "[e-mail]"
+)
+
 func newTestEnvAndUser(t *testing.T) (*testEnv, string) {
 	t.Helper()
 
 	testEnv := newTestEnv(t)
 
 	opts := createUserOptions{
-		name:           "John Doe",
-		email:          "[e-mail]",
+		name:           testUserName,
+		email:          testUserEmail,
 		avatarURL:      "",
 		nonInteractive: true,
 	}
@@ -29,8 +33,6 @@ func newTestEnvAndUser(t *testing.T) (*testEnv, string) {
 }
 
 func TestUserCreateCommand(t *testing.T) {
-	testEnv, userID := newTestEnvAndUser(t)
-
-	require.FileExists(t, filepath.Join(testEnv.cwd, ".git", "refs", "identities", userID))
-	require.FileExists(t, filepath.Join(testEnv.cwd, ".git", "git-bug", "identity-cache"))
+	_, userID := newTestEnvAndUser(t)
+	require.Regexp(t, "[0-9a-f]{64}", userID)
 }